From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#5718: scroll-margin in buffer with small line count. Date: Mon, 12 Sep 2016 08:19:59 +0200 Message-ID: <57D6490F.1000103@gmx.at> References: <4B9D1C61.70903@gmail.com> <87mvkjy0l5.fsf@users.sourceforge.net> <83fuqbfhpb.fsf@gnu.org> <87a8ggwcoo.fsf@users.sourceforge.net> <83inv4cc0s.fsf@gnu.org> <87d1ka17dr.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1473661283 15839 195.159.176.226 (12 Sep 2016 06:21:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Sep 2016 06:21:23 +0000 (UTC) Cc: ahyatt@gmail.com, 5718@debbugs.gnu.org, gavenkoa@gmail.com To: npostavs@users.sourceforge.net, Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Sep 12 08:21:19 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjKcE-0002ys-3w for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Sep 2016 08:21:14 +0200 Original-Received: from localhost ([::1]:40390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjKcC-0004Xm-0t for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Sep 2016 02:21:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60073) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjKc6-0004Xf-U1 for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 02:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjKc2-0006S0-Ni for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 02:21:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59256) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjKc2-0006Rm-KV for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 02:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bjKc2-00076z-EJ for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2016 02:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2016 06:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5718 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 5718-submit@debbugs.gnu.org id=B5718.147366122927270 (code B ref 5718); Mon, 12 Sep 2016 06:21:02 +0000 Original-Received: (at 5718) by debbugs.gnu.org; 12 Sep 2016 06:20:29 +0000 Original-Received: from localhost ([127.0.0.1]:56968 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjKbU-00075m-Ul for submit@debbugs.gnu.org; Mon, 12 Sep 2016 02:20:29 -0400 Original-Received: from mout.gmx.net ([212.227.17.21]:59765) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bjKbT-00075Z-Pa for 5718@debbugs.gnu.org; Mon, 12 Sep 2016 02:20:28 -0400 Original-Received: from [192.168.1.100] ([212.95.7.85]) by mail.gmx.com (mrgmx101) with ESMTPSA (Nemesis) id 0MCxfb-1brtJt44wd-009kcI; Mon, 12 Sep 2016 08:20:07 +0200 In-Reply-To: <87d1ka17dr.fsf@users.sourceforge.net> X-Provags-ID: V03:K0:szjuv+g3ZTxjuwTB/BMxB+NDSSpScmEXweih1I75Zy202oj656c YqJFpdIHcUTiNRV5X8pySa+RILOYCqZZFQw/Ejn/jM76rFa3TJwgqG/ctPev+ZC3LPsXlPJ iiokfR6y7oSPXcbXW0F7sBFo9r36WWahILzO+c2JavPeY4Bfz0e7UxpuSo07CPdWKFuBW8T do8xVSZafhvf6ATsM+PQA== X-UI-Out-Filterresults: notjunk:1;V01:K0:9V0MozD7ww0=:7CDKmFA4INMLy+okVlAvIA NYbtoUxjC7y+GyiCfJWRScyb1+Ns0WdzhJniyu9Eu6siwJ7ER7VorfNml1xtGIe5fGTcWnYQ2 /oIZod7742Z4jDnJw1xFyuThuNlxpOrEz/U+R+ctn5M+CDzerbOsyF5maIfGfdRM4OMuP+Ktk rN7BUXG/UlbR4wrwkZeMBr7CdflCi7nMoa2qfS7+LW3/DE2r1ldMTNefE21QRvsz5QMj4r+y4 g91SN2SxODQyikTVCXI+HXqk7nRGgactA0cr90ns0XCc9NlyDkrA0fqqMEc99xBsVHVj5OZLW CoFu35hhEr+09GrukpNPcbVnoz8whaT00LBwSP3/UhygZQGtk6S6TuVCKR0s0x3tylu4ZYslr nlCyZyRA569VcHW+WIIB17pdXArzIFjqe3WX1H/MfQ5kB493m7btYgdBs40LVqvrn9uTYVsuU sXq9NIhTE4RGgxyv4lRCJl6z736ulSh1+lbArQRVyQkXhb6QiWxrBKYq4XnsQhf4qVfWjOLGj cMEGaDjpRJDeVvqZFxkBFI1l+QGKzZZ8L2DZjD1+cEtP5rYgpfGa4nvAm3U2mB38BVMwjM2de yuWS9Gv2VnwKJ1uVn0YE4tx0cr/kHt4gE9WSfe8D6N3w1ATuJk2HdE0td02757VVrKy7B167V Hct85kR8ch7wJjFX9eUUfTd9NTiWSj8egB/QRjuHjIvE8JWy1e3f2gQ18SqeD/ulMjhqi8/5z LzEYbw2wT4k/5SiGtUvs/dZfZHT1aAXi5zt01tJxGLqYb9LQxZLDN0uFPXHzuZtTQfoRKwft X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:123206 Archived-At: > I have a patch set for fixing this and allowing the user to change the= > maximum margin from 0.25. The latter doesn't quite work perfectly, fo= r > some reason when setting the maximum margin to 0.5 and scroll-margin t= o > 100, `scroll-down-command' doesn't keep point centered in the window, > even though other commands (e.g. `scroll-up-command') do. The patches= > come with tests demonstrating this (the tests only work in interactive= > mode). Thank you. int window_total_lines - =3D window->total_lines * WINDOW_FRAME_LINE_HEIGHT (window) + =3D (window->total_lines * WINDOW_FRAME_LINE_HEIGHT (window) + - WINDOW_MODE_LINE_HEIGHT (window)) Please use another name instead of "window_total_lines" here. And please explain why you can't use Fwindow_text_height here (i.e., why header lines, horizontal scrollbars and window dividers apparently don't count). +(defmacro window-with-test-buffer-window (&rest body) Please call it =E2=80=98window-test-with-test-buffer-window=E2=80=99 to c= onsistentlyy keep the =E2=80=98window-test-=E2=80=99 prefix on everything defined in t= his file. martin