From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 24368@debbugs.gnu.org
Subject: bug#24368: 25.1; Assertion failure in attach_marker
Date: Tue, 06 Sep 2016 18:09:58 +0200 [thread overview]
Message-ID: <57CEEA56.106@gmx.at> (raw)
In-Reply-To: <83inu9awwr.fsf@gnu.org>
> On second thought, I don't think attach_marker should be touched at
> all. It is too low-level, and the assertions compile to nothing in a
> build without --enable-checking, so we will be left without any
> protection in the production version.
Right. The init_iterator problem cannot be solved this way.
> Instead, I think the callers of attach_marker should make sure charpos
> and bytepos come from the same buffer, and are therefore in sync. The
> patch below implements that; WDYT?
It fixes all issues I've encountered so far ;-)
> I agree that erroring out of goto-char in this case is sub-optimal at
> best.
Could we drop that restriction with your changes? I'd rather have this
handled safely at one place only.
> I chose neither ;-) The patch below seems to fix all of your test
> cases, including the original problem with window-state-get, even
> before it was fixed. It also lifts the restriction on goto-char.
>
> Comments?
Install!
> P.S. After fixing the crashes and correcting window--state-get-1,
> running your original test case causes "C-x 1" stop working: it has no
> effect. Looks like this is because Emacs thinks the window is the
> major non-side window, although actually I have *scratch* and *Help*,
> so the command ought to work. Is this related or unrelated to the
> issue at hand?
I'm not sure what you mean with "stop working". The idea is that C-x 1
when invoked in *scratch* should leave the *Help* window alone. If you
split *scratch* via C-x 2 and after that you do C-x 1, only the other
*scratch* window should get deleted. C-x 1 invoked in *Help* should
cause an error.
I'm currently trying to fix errors and write documentation on side
windows - that's how I stumbled into this marker issue in the first
place.
martin
next prev parent reply other threads:[~2016-09-06 16:09 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-05 7:25 bug#24368: 25.1; Assertion failure in attach_marker martin rudalics
2016-09-05 14:30 ` martin rudalics
2016-09-05 14:35 ` martin rudalics
2016-09-05 14:45 ` martin rudalics
2016-09-05 16:26 ` Eli Zaretskii
2016-09-05 15:04 ` martin rudalics
2016-09-05 16:25 ` Eli Zaretskii
2016-09-05 17:34 ` martin rudalics
2016-09-05 17:52 ` Eli Zaretskii
2016-09-05 17:58 ` martin rudalics
2016-09-05 18:25 ` Eli Zaretskii
2016-09-05 20:28 ` martin rudalics
2016-09-06 6:44 ` martin rudalics
2016-09-06 14:50 ` Noam Postavsky
2016-09-06 15:35 ` martin rudalics
2016-09-06 15:52 ` Eli Zaretskii
2016-09-06 15:08 ` Eli Zaretskii
2016-09-06 16:09 ` martin rudalics [this message]
2016-09-06 16:39 ` Eli Zaretskii
2016-09-06 16:50 ` Eli Zaretskii
2016-09-07 14:52 ` martin rudalics
2016-09-07 15:06 ` Eli Zaretskii
2016-09-07 15:19 ` martin rudalics
2016-09-07 15:47 ` Eli Zaretskii
2016-10-07 8:52 ` martin rudalics
2016-09-06 17:28 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57CEEA56.106@gmx.at \
--to=rudalics@gmx.at \
--cc=24368@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.