all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: David Reitter <david.reitter@gmail.com>
To: 5973@debbugs.gnu.org
Subject: bug#5973: Acknowledgement (Crash in get_next_display_element)
Date: Mon, 19 Apr 2010 12:46:26 -0400	[thread overview]
Message-ID: <57BEDD3C-658C-4DA0-9455-BFC0415CDBD8@gmail.com> (raw)
In-Reply-To: <handler.5973.B.12716933351499.ack@debbugs.gnu.org>

In line what is done just below in the same function, I would suggest at least the following change

diff --git a/src/xdisp.c b/src/xdisp.c
index 91fd06e..4fc4f56 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -5930,6 +5930,8 @@ get_next_display_element (it)
     {
       struct face *face = FACE_FROM_ID (it->f, it->face_id);
 
+      if (face) /* is face id valid? */
+	{
       if (it->what == IT_COMPOSITION && it->cmp_it.ch >= 0)
 	{
 	  /* Automatic composition with glyph-string.   */
@@ -5945,6 +5947,7 @@ get_next_display_element (it)
 
 	  it->face_id = FACE_FOR_CHAR (it->f, face, it->c, pos, it->string);
 	}
+	}
     }
 #endif
 






  parent reply	other threads:[~2010-04-19 16:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-19 16:08 bug#5973: Crash in get_next_display_element David Reitter
     [not found] ` <handler.5973.B.12716933351499.ack@debbugs.gnu.org>
2010-04-19 16:46   ` David Reitter [this message]
2010-04-19 17:31     ` bug#5973: Acknowledgement (Crash in get_next_display_element) Eli Zaretskii
2010-04-19 17:23 ` bug#5973: Crash in get_next_display_element Eli Zaretskii
2010-04-19 17:40   ` David Reitter
2010-04-19 18:26     ` Eli Zaretskii
2010-04-19 18:39       ` David Reitter
2010-04-19 18:43         ` Eli Zaretskii
2010-04-19 22:46       ` Juanma Barranquero
2010-04-20  8:23         ` Eli Zaretskii
2010-04-20  9:19           ` Juanma Barranquero
2010-04-20  9:56             ` Eli Zaretskii
2010-04-20 10:27               ` Juanma Barranquero
2010-04-20 12:31                 ` Eli Zaretskii
2010-04-20 13:36                   ` Juanma Barranquero
2010-04-20 13:56                   ` Juanma Barranquero
2010-04-20 10:21         ` Eli Zaretskii
2010-04-20 10:33           ` Juanma Barranquero
2010-04-20 12:23             ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57BEDD3C-658C-4DA0-9455-BFC0415CDBD8@gmail.com \
    --to=david.reitter@gmail.com \
    --cc=5973@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.