From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#24281: 25.1; (next-frame nil t) crashes Date: Sun, 21 Aug 2016 19:15:59 +0200 Message-ID: <57B9E1CF.3080407@gmx.at> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1471799841 18339 195.159.176.226 (21 Aug 2016 17:17:21 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 Aug 2016 17:17:21 +0000 (UTC) To: 24281@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Aug 21 19:17:16 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbWN1-0004PE-R2 for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Aug 2016 19:17:16 +0200 Original-Received: from localhost ([::1]:37632 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbWMy-0001rS-Nx for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Aug 2016 13:17:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57141) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbWMs-0001rL-PG for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 13:17:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbWMo-0004Dz-HN for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 13:17:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:38333) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbWMo-0004Dt-EX for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 13:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bbWMo-00072n-56 for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 13:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Aug 2016 17:17:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 24281 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Bug-Gnu-Emacs Original-Received: via spool by submit@debbugs.gnu.org id=B.147179978227022 (code B ref -1); Sun, 21 Aug 2016 17:17:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 21 Aug 2016 17:16:22 +0000 Original-Received: from localhost ([127.0.0.1]:36045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbWMA-00071m-HG for submit@debbugs.gnu.org; Sun, 21 Aug 2016 13:16:22 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bbWM8-00071a-NI for submit@debbugs.gnu.org; Sun, 21 Aug 2016 13:16:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbWM2-0004BS-AH for submit@debbugs.gnu.org; Sun, 21 Aug 2016 13:16:15 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:54474) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbWM2-0004BO-7K for submit@debbugs.gnu.org; Sun, 21 Aug 2016 13:16:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57083) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbWLz-0001q5-RT for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 13:16:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bbWLv-0004Av-K1 for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 13:16:10 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:62371) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bbWLv-0004Ar-AI for bug-gnu-emacs@gnu.org; Sun, 21 Aug 2016 13:16:07 -0400 Original-Received: from [192.168.1.100] ([212.95.7.48]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0MRjd7-1bhkXn031V-00T0cr for ; Sun, 21 Aug 2016 19:16:06 +0200 X-Provags-ID: V03:K0:5je6ZzKZdvr8CSwIZ12jb5q2vOOXX+bRv5ohqZOcYhmKOIFeTSY LRNzrLekZAnGh0gx4JgNck6meAFljhi0F0aN8DgZYH4RXbICyGP2iYCI6Lvb1YbSWXC16AP dmAV1nDDcWON5kfOWzKiOF7I1t47fxGfM3VQd8uE1wM17QMQNovgCl6ut177WGZmwOPIWPp KvKyf4Rz0M8LhVlsmLohQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:+78TR4v0b0M=:xR8e+xnB/YNPhRD7m4gY7U T6soAjc9/NPtIAbAy8HjN2ZC6L2eqO6alb+q/FG0IyiVfaACsM1nr+050mdxzAHFLW2iIWoOy pomknPphcQe9l+Z0B0Dw2NQlUBosm2bRo3Jr1Xv426wB7RuXzD6Kc15/XDRIPsm6qDWNIYt4h vy0tVCN9QLtI5Ud3sn5zgktRm5C62JV2ZvyU/QWD4LJeb6XleEqnWXHGlbPtq/kaEI0JKp4R6 61zo0WoFOfb2EDg4woXqHs5drlwIbI2EOBbBeeaLmRay+3qSzHfk9EZMIxLPwtOfUGnjvo5dN Vg5ok7mzddsbohQlbprSACuiXozjAcqGCEgHnZyS9l9TreebzdTyNurl0ZDt9Ao2V3qMDKArm KcNsnb3zugL4oVoldPdb8Xi4ei7ZiPQflywxGbEdCNIJTv/vlmhOvYc1yk+OiAzc2373f6QSG ZnEKZ3lEWpDgUpwF/rrWLrKl9rmEfQxDOGEPWnBzXW7gcqXhJ5yCDKP1MZZvuoeWqebw1qSXF RgbDpotG+S+JGoxvxt6a/+/xvAvkS9BjBAmShS2KmGlpn02Y+9jbv9YzTMg065oHEzGx+CK9k AkeChazz1YNBtXO865HJ/xqW3I/at1hntg06FhAhyuhhf2i15D9O36BvAFpHz7eGfOrE5v7JW dc3tEDJGRseob/jg6Y3Ypubxsfi/D4IV/bskZww2QGgPYZB4+acxtyrRtFqurAgEo5aXan37Q g4bhkR3YbmBg8eclro/GkwvPV1jGRpktDHpyj6RGKwaebNv+h1MsSe6OKutN/C0KBqUp0QwZ X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:122462 Archived-At: With emacs -Q evaluating (next-frame nil t) currently crashes as: (gdb) bt #0 terminate_due_to_signal (sig=22, backtrace_limit=2147483647) at emacs.c:354 #1 0x011f1adf in die (msg=0x1642607 "0 <= n", file=0x1642600 "lisp.h", line=916) at alloc.c:7223 #2 0x01143da3 in XFASTINT (a=...) at lisp.h:916 #3 0x0101794f in candidate_frame (candidate=..., frame=..., minibuf=...) at frame.c:1311 #4 0x01017a53 in next_frame (frame=..., minibuf=...) at frame.c:1338 #5 0x01017f06 in Fnext_frame (frame=..., miniframe=...) at frame.c:1396 #6 0x0121e882 in eval_sub (form=...) at eval.c:2169 #7 0x0121d9f5 in Feval (form=..., lexical=...) at eval.c:1988 #8 0x0122085f in Ffuncall (nargs=3, args=0x82e0e8) at eval.c:2696 #9 0x0127d391 in exec_byte_code (bytestr=..., vector=..., maxdepth=..., args_template=..., nargs=1, args=0x82e690) at bytecode.c:880 #10 0x01221620 in funcall_lambda (fun=..., nargs=1, arg_vector=0x82e688) at eval.c:2855 #11 0x01220c2e in Ffuncall (nargs=2, args=0x82e680) at eval.c:2742 #12 0x0127d391 in exec_byte_code (bytestr=..., vector=..., maxdepth=..., args_template=..., nargs=1, args=0x82ed78) at bytecode.c:880 #13 0x01221620 in funcall_lambda (fun=..., nargs=1, arg_vector=0x82ed70) at eval.c:2855 #14 0x01220c2e in Ffuncall (nargs=2, args=0x82ed68) at eval.c:2742 #15 0x01212c52 in Ffuncall_interactively (nargs=2, args=0x82ed68) at callint.c:252 #16 0x012206cf in Ffuncall (nargs=3, args=0x82ed60) at eval.c:2673 #17 0x01215e4e in Fcall_interactively (function=..., record_flag=..., keys=...) at callint.c:840 #18 0x012208b6 in Ffuncall (nargs=4, args=0x82f1c8) at eval.c:2700 #19 0x0127d391 in exec_byte_code (bytestr=..., vector=..., maxdepth=..., args_template=..., nargs=1, args=0x82f780) at bytecode.c:880 #20 0x01221620 in funcall_lambda (fun=..., nargs=1, arg_vector=0x82f778) at eval.c:2855 #21 0x01220c2e in Ffuncall (nargs=2, args=0x82f770) at eval.c:2742 #22 0x0121ff7f in call1 (fn=..., arg1=...) at eval.c:2552 #23 0x011515c3 in command_loop_1 () at keyboard.c:1479 #24 0x0121b4f2 in internal_condition_case (bfun=0x1150af7 , handlers=..., hfun=0x114fd8f ) at eval.c:1309 #25 0x01150591 in command_loop_2 (ignore=...) at keyboard.c:1107 #26 0x0121a696 in internal_catch (tag=..., func=0x1150555 , arg=...) at eval.c:1074 #27 0x01150517 in command_loop () at keyboard.c:1086 #28 0x0114f7a7 in recursive_edit_1 () at keyboard.c:692 #29 0x0114fa68 in Frecursive_edit () at keyboard.c:763 #30 0x0114d17e in main (argc=2, argv=0xa32658) at emacs.c:1626 Lisp Backtrace: "next-frame" (0x82ded0) "eval" (0x82e0f0) "elisp--eval-last-sexp" (0x82e688) "eval-last-sexp" (0x82ed70) "funcall-interactively" (0x82ed68) "call-interactively" (0x82f1d0) "command-execute" (0x82f778) (gdb) In GNU Emacs 25.1.1 (i686-pc-mingw32) of 2016-08-18 built on MACHNO Repository revision: 8c2946e29b38fa3e0dff6b4d402ba0fda0e03c9b Windowing system distributor 'Microsoft Corp.', version 5.1.2600 Configured using: 'configure --prefix=/c/emacs-git/next --with-wide-int --enable-checking=yes --enable-check-lisp-object-type=yes 'CFLAGS=-O0 -g3'' Looks like an almost four years old bug. Still I think we should install the below _before_ the release. --- a/src/frame.c +++ b/src/frame.c @@ -1308,7 +1308,7 @@ candidate_frame (Lisp_Object candidate, Lisp_Object frame, Lisp_Object minibuf) FRAME_FOCUS_FRAME (c))) return candidate; } - else if (XFASTINT (minibuf) == 0) + else if (INTEGERP (minibuf) && XINT (minibuf) == 0) { if (FRAME_VISIBLE_P (c) || FRAME_ICONIFIED_P (c)) return candidate; martin