From: martin rudalics <rudalics@gmx.at>
To: Andreas Politz <politza@hochschule-trier.de>
Cc: 24240@debbugs.gnu.org
Subject: bug#24240: 25.1.50; window-state-put, image-mode and window scrolling
Date: Thu, 18 Aug 2016 10:42:06 +0200 [thread overview]
Message-ID: <57B574DE.2090004@gmx.at> (raw)
In-Reply-To: <87inuzl6hc.fsf@hochschule-trier.de>
>> But do you mean that setting NOFORCE alone will handle your bug already
>> and we don't need ‘frame-after-make-frame’ after all?
>
> Yes, it would.
OK. Pushed to master. In any case it fixes a scenario like the following:
(let (window state point start)
(find-file "../lisp/window.el")
(forward-line 30)
(setq window (selected-window))
(setq state (window-state-get window))
(setq start (window-start window))
(setq point (window-point window))
(message "Before split - %s ... start: %s ... point: %s" window start point) (sit-for 3)
(split-window window)
(message "After split - %s ... start: %s ... point: %s" window start point) (sit-for 3)
(window-state-put state window)
(sit-for 0)
(message
"Final - %s ... start: %s -> %s ... point: %s -> %s"
window start (window-start window) point (window-point window)))
> At least in the case of image-mode, it would actually be preferable to
> let window-state-put override image-mode-reapply-winprops's scrolling,
> because it has the correct value. I don't know how familiar you are
> with image-mode,
Not at all.
> but if it has no record for a particular window, it
> restores the value last set in any window. The difference would be
> visible in case the buffer is shown in more than one window (with
> different scroll values).
And you mean that the situation after your fix is as expected and the
single, final call of ‘window-configuration-change-hook’ I proposed
earlier would spoil that? Technically spoken, it would fail because
‘window-state-put’ creates windows anew and for a new window image-mode
has no record of the previous position of the image in that window? Do
you agree with that interpretation?
martin
next prev parent reply other threads:[~2016-08-18 8:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-15 23:05 bug#24240: 25.1.50; window-state-put, image-mode and window scrolling Andreas Politz
2016-08-16 11:00 ` martin rudalics
2016-08-16 13:51 ` Andreas Politz
2016-08-17 8:30 ` martin rudalics
2016-08-17 10:33 ` Andreas Politz
2016-08-17 15:47 ` martin rudalics
2016-08-17 16:12 ` Andreas Politz
2016-08-18 8:42 ` martin rudalics [this message]
2016-10-30 8:47 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57B574DE.2090004@gmx.at \
--to=rudalics@gmx.at \
--cc=24240@debbugs.gnu.org \
--cc=politza@hochschule-trier.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.