From: Paul Eggert <eggert@cs.ucla.edu>
To: "Clément Pit--Claudel" <clement.pitclaudel@live.com>,
23938-done@debbugs.gnu.org
Subject: bug#23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master
Date: Mon, 11 Jul 2016 16:20:09 +0200 [thread overview]
Message-ID: <5783AB19.3020706@cs.ucla.edu> (raw)
In-Reply-To: <5782DB52.1060806@live.com>
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
Thanks for tracking that bug down and for the reproducible test case. It
was a typo in that refactoring commit; sorry about that. I installed the
attached patch into master to fix things.
[-- Attachment #2: 0001-Fix-composition-bug-caused-by-off-by-1-typo.patch --]
[-- Type: text/x-patch, Size: 888 bytes --]
From 8cb5ab5cf48362ea64c6463a8aabc4892c5352f7 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Mon, 11 Jul 2016 16:14:33 +0200
Subject: [PATCH] Fix composition bug caused by off-by-1 typo
* src/xdisp.c (x_produce_glyphs): Fix off-by-one typo when
computing composition glyph (Bug#23938).
---
src/xdisp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/xdisp.c b/src/xdisp.c
index d5ffb25..14d6f8f 100644
--- a/src/xdisp.c
+++ b/src/xdisp.c
@@ -27369,8 +27369,8 @@ x_produce_glyphs (struct it *it)
eassume (0 < glyph_len); /* See Bug#8512. */
do
- c = COMPOSITION_GLYPH (cmp, --glyph_len);
- while (c == '\t' && 0 < glyph_len);
+ c = COMPOSITION_GLYPH (cmp, glyph_len - 1);
+ while (c == '\t' && 0 < --glyph_len);
bool right_padded = glyph_len < cmp->glyph_len;
for (i = 0; i < glyph_len; i++)
--
2.5.5
next prev parent reply other threads:[~2016-07-11 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-10 23:33 bug#23938: Commit 237244bbd5ce753bcdf79634561de515bd76c687 broke display of composed characters on master Clément Pit--Claudel
2016-07-11 14:20 ` Paul Eggert [this message]
2016-07-11 14:21 ` Eli Zaretskii
2016-07-11 14:36 ` Paul Eggert
2016-07-11 15:04 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5783AB19.3020706@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=23938-done@debbugs.gnu.org \
--cc=clement.pitclaudel@live.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.