From: Jim Porter <jporterbugs@gmail.com>
To: Christopher Howard <christopher@librehacker.com>
Cc: 70847@debbugs.gnu.org
Subject: bug#70847: 29.3; eshell scripts "from anywhere"
Date: Tue, 28 May 2024 14:51:07 -0700 [thread overview]
Message-ID: <5760b900-2b5e-14c4-b01d-b1ab21198df8@gmail.com> (raw)
In-Reply-To: <87le3tvi3b.fsf@librehacker.com>
On 5/28/2024 12:42 PM, Christopher Howard wrote:
> Then, M-x eshell-command echo blah RET
>
> Under my normal 29.3 I expect to see "blah" echoed to the message area, but instead I get this error:
>
>> Debugger entered--Lisp error: (wrong-type-argument number-or-marker-p nil)
>> eshell-add-input-to-history("echo hello")
>> eshell-read-command()
>> byte-code("\301 \10D\207" [current-prefix-arg eshell-read-command] 2)
>> call-interactively(eshell-command record nil)
>> command-execute(eshell-command record)
>> execute-extended-command(nil "eshell-command" "eshell-comma")
>> funcall-interactively(execute-extended-command nil "eshell-command" "eshell-comma")
>> call-interactively(execute-extended-command nil nil)
>> command-execute(execute-extended-command)
Thanks for catching this. I believe this ultimately broke due to the fix
in bug#66700, but as far as I can tell, the intended behavior (adding to
Eshell's history file for 'eshell-command') had been broken for a lot
longer. I've pushed a fix to the master branch for this part. This is
one of those bits that's annoying to write regression tests for since it
relies on interactive calls and using the minibuffer...
I don't think that should impact the other patches I've posted to this
bug one way or the other though.
next prev parent reply other threads:[~2024-05-28 21:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 17:57 bug#70847: 29.3; eshell scripts "from anywhere" Christopher Howard
2024-05-23 20:30 ` Jim Porter
2024-05-24 14:27 ` Christopher Howard
2024-05-25 2:17 ` Jim Porter
2024-05-28 19:42 ` Christopher Howard
2024-05-28 21:51 ` Jim Porter [this message]
2024-05-28 19:46 ` Christopher Howard
2024-05-28 22:49 ` Christopher Howard
2024-05-29 0:31 ` Jim Porter
2024-05-29 14:16 ` Christopher Howard
2024-05-29 19:22 ` Jim Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5760b900-2b5e-14c4-b01d-b1ab21198df8@gmail.com \
--to=jporterbugs@gmail.com \
--cc=70847@debbugs.gnu.org \
--cc=christopher@librehacker.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.