all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Clément Pit--Claudel" <clement.pitclaudel@live.com>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>, Glenn Morris <rgm@gnu.org>
Cc: 23692@debbugs.gnu.org
Subject: bug#23692: 25.1.50; Package.el gets confused if file has no autoloads (could be a bug in update-directory-autoloads)
Date: Mon, 13 Jun 2016 18:17:02 -0400	[thread overview]
Message-ID: <575F30DE.909@live.com> (raw)
In-Reply-To: <jwva8ivyw0m.fsf-monnier+emacsbugs@gnu.org>


[-- Attachment #1.1: Type: text/plain, Size: 982 bytes --]

Yup, works for me!

On 2016-06-08 21:47, Stefan Monnier wrote:
>>>> When the a single-package file has no autoloads, the call to
>>>> update-directory-autoloads leaves the generated autoload files
>>>> modified, but unsaved. This causes package.el to prompt the user
>>>> about killing a modified file.
> 
> Does the patch below fix the problem for you?
> 
> 
>         Stefan
> 
> 
> diff --git a/lisp/emacs-lisp/autoload.el b/lisp/emacs-lisp/autoload.el
> index 6473e31..9cf96fd 100644
> --- a/lisp/emacs-lisp/autoload.el
> +++ b/lisp/emacs-lisp/autoload.el
> @@ -1111,7 +1111,8 @@ write its autoloads into the specified file instead."
>  
>        ;; Don't modify the file if its content has not been changed, so `make'
>        ;; dependencies don't trigger unnecessarily.
> -      (when changed
> +      (if (not changed)
> +          (set-buffer-modified-p nil)
>          (let ((version-control 'never))
>            (save-buffer)))
>  
> 
> 


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      parent reply	other threads:[~2016-06-13 22:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-03 22:03 bug#23692: 25.1.50; Package.el gets confused if file has no autoloads (could be a bug in update-directory-autoloads) Clément Pit--Claudel
2016-06-03 22:50 ` Glenn Morris
2016-06-04  4:34   ` Clément Pit--Claudel
2016-06-06 17:24   ` Glenn Morris
2016-06-09  1:47     ` Stefan Monnier
2016-06-13 18:33       ` Glenn Morris
2016-06-14  0:40         ` Stefan Monnier
2016-10-10  9:56           ` Eli Zaretskii
2016-10-11 19:56             ` Stefan Monnier
2016-10-11 20:54               ` Eli Zaretskii
2016-06-13 22:17       ` Clément Pit--Claudel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=575F30DE.909@live.com \
    --to=clement.pitclaudel@live.com \
    --cc=23692@debbugs.gnu.org \
    --cc=monnier@IRO.UMontreal.CA \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.