From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Guilhem Bichot Newsgroups: gmane.emacs.bugs Subject: bug#23720: 25.0.94; Issues with GUD (gdb-mi) after upgrade from Emacs 23 to 24/25 Date: Thu, 9 Jun 2016 09:42:23 +0200 Message-ID: <57591DDF.4030900@oracle.com> References: <5756941E.3000700@oracle.com> <837fe0syx5.fsf@gnu.org> <8337oosubh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1465458212 14312 80.91.229.3 (9 Jun 2016 07:43:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 9 Jun 2016 07:43:32 +0000 (UTC) Cc: 23720@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jun 09 09:43:18 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bAucY-0004GB-19 for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Jun 2016 09:43:18 +0200 Original-Received: from localhost ([::1]:32886 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAucT-0004RM-Ta for geb-bug-gnu-emacs@m.gmane.org; Thu, 09 Jun 2016 03:43:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53071) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAucN-0004R7-N2 for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2016 03:43:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bAucI-00058G-KO for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2016 03:43:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49193) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bAucI-00058B-Gg for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2016 03:43:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bAucI-00005c-A0 for bug-gnu-emacs@gnu.org; Thu, 09 Jun 2016 03:43:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Guilhem Bichot Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 09 Jun 2016 07:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23720 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23720-submit@debbugs.gnu.org id=B23720.1465458160311 (code B ref 23720); Thu, 09 Jun 2016 07:43:02 +0000 Original-Received: (at 23720) by debbugs.gnu.org; 9 Jun 2016 07:42:40 +0000 Original-Received: from localhost ([127.0.0.1]:33297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAubw-00004x-CS for submit@debbugs.gnu.org; Thu, 09 Jun 2016 03:42:40 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:38979) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bAubv-0008WP-2I for 23720@debbugs.gnu.org; Thu, 09 Jun 2016 03:42:39 -0400 Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u597gWT7011357 (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Jun 2016 07:42:32 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.13.8/8.13.8) with ESMTP id u597gVvk001161 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 9 Jun 2016 07:42:32 GMT Original-Received: from abhmp0013.oracle.com (abhmp0013.oracle.com [141.146.116.19]) by aserv0122.oracle.com (8.13.8/8.13.8) with ESMTP id u597gTnE002118; Thu, 9 Jun 2016 07:42:30 GMT Original-Received: from [10.175.202.2] (/10.175.202.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 09 Jun 2016 00:42:29 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 In-Reply-To: <8337oosubh.fsf@gnu.org> X-Source-IP: aserv0021.oracle.com [141.146.126.233] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119315 Archived-At: Hello, Eli Zaretskii a écrit le 07/06/2016 20:54 : >> Date: Tue, 07 Jun 2016 20:15:34 +0300 >> From: Eli Zaretskii >> Cc: 23720@debbugs.gnu.org >> >>> ISSUE 3: STEPPING OUT DOESN'T PRINT RETURN VALUE >>> ================================================ >>> >>> The program is in the stepped-in function, clicking "Step out" steps out >>> of it, but this doesn't print the returned value. >>> Emacs23 prints it ("Value returned is $1 = false"). >> >> Looks like a missing feature in gdb-mi: the return value sent by MI is >> not processed. > > Please try the patch below, I think it will fix this. > > diff --git a/lisp/progmodes/gdb-mi.el b/lisp/progmodes/gdb-mi.el > index 5ad101d..195acaf 100644 > --- a/lisp/progmodes/gdb-mi.el > +++ b/lisp/progmodes/gdb-mi.el > @@ -2488,7 +2488,9 @@ gdb-stopped > ;; Reason is available with target-async only > (let* ((result (gdb-json-string output-field)) > (reason (bindat-get-field result 'reason)) > - (thread-id (bindat-get-field result 'thread-id))) > + (thread-id (bindat-get-field result 'thread-id)) > + (retval (bindat-get-field result 'return-value)) > + (varnum (bindat-get-field result 'gdb-result-var))) > > ;; -data-list-register-names needs to be issued for any stopped > ;; thread > @@ -2514,6 +2516,11 @@ gdb-stopped > (if (string-equal reason "exited-normally") > (setq gdb-active-process nil)) > > + (when (and retval varnum) > + (setq gdb-filter-output > + (concat gdb-filter-output > + (format "Value returned is %s = %s\n" varnum retval)))) > + > ;; Select new current thread. > > ;; Don't switch if we have no reasons selected yes, it works! thanks! Please, could you consider incorporating this into the next releases?