From: martin rudalics <rudalics@gmx.at>
To: Stephen Berman <stephen.berman@gmx.net>, 23690@debbugs.gnu.org
Subject: bug#23690: 25.0.94; Window resizing regression
Date: Fri, 03 Jun 2016 15:54:11 +0200 [thread overview]
Message-ID: <57518C03.9090005@gmx.at> (raw)
In-Reply-To: <87wpm6lavk.fsf@gmx.net>
[-- Attachment #1: Type: text/plain, Size: 1534 bytes --]
> 0. emacs -Q
> 1. Type `C-x 3' to split the selected window into two side-by-side
> windows.
> 2. Sanity check: click mouse-1 on the divider between the mode lines,
> and observe that by dragging the mouse you can move the vertical
> boundary between the windows to the left or right.
> 3. In the menu Options->Show/Hide->Scroll-bar click the "On the Left"
> button to make the scroll bars appear on the left side of the
> windows.
> 4. Repeat step 2.
> => The vertical boundary between the windows does not change, but
> instead the echo area displays the message "No window on the right of
> this one" (although the selected window is the one on the left).
>
> This is a regression from Emacs 24.5, where step 4 works just like step
> 2. Git bisect identifies the following as the responsible commit:
>
> commit 3110159d1fb6b6071803355951d9ae314095df36
> Author: Martin Rudalics <rudalics@gmx.at>
> Date: Fri Oct 24 11:58:43 2014 +0200
>
> Improve mouse dragging of frame edges.
>
> * keyboard.c (make_lispy_position): Return coordinates also when
> on scroll bars, fringes, margins or not in a window.
> * xdisp.c (show_mouse_face): Don't change cursor face during
> mouse tracking.
> * mouse.el (mouse-drag-line): Don't use mouse-pixel-position.
> Calculate increment from last position instead of window edge.
> Add right- and bottom-divider bindings to transient map.
Would the attached patch fix it for you?
Thanks, martin
[-- Attachment #2: mouse.diff --]
[-- Type: text/plain, Size: 762 bytes --]
diff --git a/lisp/mouse.el b/lisp/mouse.el
index fa355ff..592338a 100644
--- a/lisp/mouse.el
+++ b/lisp/mouse.el
@@ -406,7 +406,15 @@ mouse-drag-line
(or (not resize-mini-windows)
(eq minibuffer-window
(active-minibuffer-window)))))))
- (setq draggable nil))))
+ (setq draggable nil)))
+ ((eq line 'vertical)
+ (let ((divider-width (frame-right-divider-width frame)))
+ (when (and (or (not (numberp divider-width))
+ (zerop divider-width))
+ (eq (cdr (assq 'vertical-scroll-bars
+ (frame-parameters frame)))
+ 'left))
+ (setq window (window-in-direction 'left window t))))))
(let* ((exitfun nil)
(move
next prev parent reply other threads:[~2016-06-03 13:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 12:23 bug#23690: 25.0.94; Window resizing regression Stephen Berman
2016-06-03 13:54 ` martin rudalics [this message]
2016-06-03 14:30 ` Stephen Berman
2016-06-04 9:48 ` martin rudalics
2016-06-04 10:53 ` Eli Zaretskii
2016-06-04 11:12 ` Stephen Berman
2016-06-04 13:07 ` martin rudalics
2016-06-04 15:05 ` Eli Zaretskii
2016-06-05 9:53 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57518C03.9090005@gmx.at \
--to=rudalics@gmx.at \
--cc=23690@debbugs.gnu.org \
--cc=stephen.berman@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.