From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Note on e65c307 breaks font-height Date: Sun, 29 May 2016 10:14:08 -0700 Organization: UCLA Computer Science Department Message-ID: <574B2360.7070809@cs.ucla.edu> References: <5746D38F.4010203@gmx.at> <4cdc1b55-2fe2-2457-1115-33ff68a9a65d@cs.ucla.edu> <5748490A.6020906@gmx.at> <57497527.8050600@cs.ucla.edu> <574AF21D.30602@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040504080404020003000108" X-Trace: ger.gmane.org 1464542107 13382 80.91.229.3 (29 May 2016 17:15:07 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 29 May 2016 17:15:07 +0000 (UTC) To: martin rudalics , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun May 29 19:14:58 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1b74Ih-0003YR-LI for ged-emacs-devel@m.gmane.org; Sun, 29 May 2016 19:14:55 +0200 Original-Received: from localhost ([::1]:56477 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b74Ig-0002Qf-QH for ged-emacs-devel@m.gmane.org; Sun, 29 May 2016 13:14:54 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48327) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b74I8-0002QX-SI for emacs-devel@gnu.org; Sun, 29 May 2016 13:14:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b74I2-0000jz-QZ for emacs-devel@gnu.org; Sun, 29 May 2016 13:14:19 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b74I2-0000js-Ih for emacs-devel@gnu.org; Sun, 29 May 2016 13:14:14 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 501C91613EF; Sun, 29 May 2016 10:14:13 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id IX3Hz5_Ib4vM; Sun, 29 May 2016 10:14:12 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 49C1C1613F2; Sun, 29 May 2016 10:14:12 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id r5eT2FB-0L51; Sun, 29 May 2016 10:14:12 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 283FF1613EF; Sun, 29 May 2016 10:14:12 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 In-Reply-To: <574AF21D.30602@gmx.at> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:204132 Archived-At: This is a multi-part message in MIME format. --------------040504080404020003000108 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable martin rudalics wrote: > I have no idea what the --eval is for. I put that --eval in only because Rostislav Svoboda's bug report mentione= d it=20 and I thought that it was needed to reproduce the bug. > > And in both Emacs 24.5 and emacs-25 if I reapply .emacs the > > display changes to the same (nicer) appearance. > > But in Emacs 25 I have to _manually_ reapply .emacs. Yes, that is annoying. But I had to manually reapply .emacs in Emacs 24.5= too,=20 with the scenario involving --eval. So this was not a regression for me i= n that=20 case, which means I haven't reproduced your bug yet.... > dynamic-setting-handle-config-changed-event: Symbol=E2=80=99s value as = variable is void: > default-face-font-user-spec Ach, that was a stupid last-minute typo. Revised patch attached. --------------040504080404020003000108 Content-Type: text/x-diff; name="0001-Fix-face-attribute-default-settings.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-Fix-face-attribute-default-settings.patch" =46rom 7838d6e99dc0c191e16c4bf8849a1696ef7f2167 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 29 May 2016 10:03:05 -0700 Subject: [PATCH] Fix face attribute default settings Problem reported by Martin Rudalics in: http://lists.gnu.org/archive/html/emacs-devel/2016-05/msg00557.html * lisp/dynamic-setting.el (font-setting-change-default-font): Don't confuse default face font user spec with frame font. --- lisp/dynamic-setting.el | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/lisp/dynamic-setting.el b/lisp/dynamic-setting.el index 6021a3b..b1d2397 100644 --- a/lisp/dynamic-setting.el +++ b/lisp/dynamic-setting.el @@ -53,17 +53,17 @@ font-setting-change-default-font (set-frame-font new-font nil frame-list) ;; Just redraw the existing fonts on all frames: (dolist (f frame-list) - (let ((frame-font - (or (font-get (face-attribute 'default :font f 'default) - :user-spec) - (frame-parameter f 'font-parameter)))) + (let ((user-spec (font-get (face-attribute 'default :font f 'default)= + :user-spec)) + (frame-font (frame-parameter f 'font-parameter))) (when frame-font - (set-frame-parameter f 'font-parameter frame-font) + (set-frame-parameter f 'font-parameter frame-font)) + (when user-spec (set-face-attribute 'default f :width 'normal :weight 'normal :slant 'normal - :font frame-font)))))))) + :font user-spec)))))))) =20 (defun dynamic-setting-handle-config-changed-event (event) "Handle config-changed-event on the display in EVENT. @@ -92,4 +92,3 @@ dynamic-setting-handle-config-changed-event =20 (define-key special-event-map [config-changed-event] 'dynamic-setting-handle-config-changed-event) - --=20 2.7.4 --------------040504080404020003000108--