From: martin rudalics <rudalics@gmx.at>
To: Paul Eggert <eggert@cs.ucla.edu>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Note on e65c307 breaks font-height
Date: Fri, 27 May 2016 15:18:02 +0200 [thread overview]
Message-ID: <5748490A.6020906@gmx.at> (raw)
In-Reply-To: <4cdc1b55-2fe2-2457-1115-33ff68a9a65d@cs.ucla.edu>
> What exactly is in your .emacs file? That is, can you give a recipe to reproduce the problem?
It's reproducible here with my
(custom-set-faces
;; custom-set-faces was added by Custom.
;; If you edit it by hand, you could mess it up, so be careful.
;; Your init file should contain only one such instance.
;; If there is more than one, they won't work right.
'(default ((t (:stipple nil :background "grey92" :foreground "black" :inverse-video nil :box nil :strike-through nil :overline nil :underline nil :slant normal :weight normal :height 98 :width normal :foundry "outline" :family "Courier New")))))
> Is there anything in your configuration (e.g., saved-desktop?) that mentions :user-spec or user-spec?
No.
> Only one place in the Emacs Lisp code uses :user-spec: font-setting-change-default-font. Perhaps it is causing the bug. Does the attached patch fix the problem?
I suppose so but didn't try it yet. IIUC it would defy the purpose of
that function. I have no idea what ‘font-setting-change-default-font’
is really about. I suppose it's related to themes but maybe someone
knows more.
My analysis so far is as follows: In ‘font-setting-change-default-font’
the disjunct (frame-parameter f 'font-parameter) always evaluates to
nil here. Before your patch, the disjunct
(or (font-get (face-attribute 'default :font f 'default)
:user-spec)
always evaluated to nil. After your patch it returns "Monospace 11" and
‘frame-font’ gets set to that and the frame's default font too. IIUC
the height of the default face gets set to that value too but a new
frame gets the value from my .emacs. As a consequence, customizing the
default face will present me different height values corresponding to
the frame where I start the customization from. That is awfully weird.
Please try with my .emacs setting on your system and tell me what you
get. Windows doesn't have (fboundp 'font-get-system-font) so the issue
is moot there.
martin
next prev parent reply other threads:[~2016-05-27 13:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 10:44 Note on e65c307 breaks font-height martin rudalics
2016-05-26 15:05 ` Paul Eggert
2016-05-26 15:22 ` Eli Zaretskii
2016-05-26 15:33 ` Paul Eggert
2016-05-26 15:50 ` Eli Zaretskii
2016-05-26 15:57 ` Paul Eggert
2016-05-26 16:33 ` Eli Zaretskii
2016-05-27 13:18 ` martin rudalics [this message]
2016-05-28 10:17 ` Eli Zaretskii
2016-05-29 13:43 ` martin rudalics
2016-05-29 15:07 ` Eli Zaretskii
2016-05-30 8:00 ` martin rudalics
2016-06-04 7:28 ` Eli Zaretskii
2016-06-04 9:48 ` martin rudalics
2016-06-04 10:52 ` Eli Zaretskii
2016-06-04 13:07 ` martin rudalics
2016-05-28 10:38 ` Paul Eggert
2016-05-29 13:43 ` martin rudalics
2016-05-29 17:14 ` Paul Eggert
2016-05-30 8:00 ` martin rudalics
2016-05-26 15:16 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5748490A.6020906@gmx.at \
--to=rudalics@gmx.at \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.