From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Renaming eglot -- or at least add an alias? Date: Wed, 12 Oct 2022 13:50:38 +0300 Message-ID: <5746b7e8-75ab-a12f-54b4-308c3ffc5b59@yandex.ru> References: <83pmfdduix.fsf@gnu.org> <86wn9ji3ma.fsf@gmail.com> <86tu4lsnqk.fsf@gmail.com> <8335c0p2fn.fsf@gnu.org> <83leproov6.fsf@gnu.org> <83fsfzonwn.fsf@gnu.org> <5a1e604c-4500-a476-da3d-259d9057a7f0@yandex.ru> <838rlromxu.fsf@gnu.org> <83h70dk3wf.fsf@gnu.org> <83fsfxk30x.fsf@gnu.org> <83r0zdd1cy.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26190"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: Richard Stallman , emacs-devel@gnu.org To: Yuan Fu , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed Oct 12 12:53:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oiZMT-0006ed-Lb for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Oct 2022 12:53:17 +0200 Original-Received: from localhost ([::1]:34160 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oiZMS-0000Ib-C5 for ged-emacs-devel@m.gmane-mx.org; Wed, 12 Oct 2022 06:53:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46226) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oiZKQ-0006xK-0j for emacs-devel@gnu.org; Wed, 12 Oct 2022 06:51:11 -0400 Original-Received: from mail-wm1-x335.google.com ([2a00:1450:4864:20::335]:42631) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oiZKN-0000Bl-K9; Wed, 12 Oct 2022 06:51:09 -0400 Original-Received: by mail-wm1-x335.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so962416wmq.1; Wed, 12 Oct 2022 03:50:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=WhJ2tsPeh7GyyXofBNJBYt/skcpMeqQWS2Ql4H4QBTk=; b=fimSbRpvsxXEfZpRF89zhetBEKa/KwbQDtLBPmHI7igYgpH3KZICJb5oEwH5fqmqax E4zS9pxVAR7/Be61Tvds3moUgwWsXXnXouzY4d4AAx8U/UkbrqziNHb0Wc4JAGMqVspx jNn2acmFJU3vvxy17dq55wJivzKA1VsjxPOr74R9NVOeOgmPZJq5pFL0TGqVeMU72Czu rBMYUOzWBjeXvgMKK9UFe/TMTXspzC6CQg+Cp40kcf7WJPhBeyl2fZbNRghvkPUEE6IS tZFqsPiypO0Okmq36OPlk+NYsjJKNKP/q+1h6p4//Mw3pZq6OhBUJlwf1OVF+NlFECiQ c/Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WhJ2tsPeh7GyyXofBNJBYt/skcpMeqQWS2Ql4H4QBTk=; b=OIkS1qQA/YA+xPvZ8DhkhTnkoVX+Im7CwY2vuz+yxkBLSeB60jBfWEcQJeH3duHoTP xmAMOjOETbj+FmVA11HQN7y9xuFSETZGuOZoAkxUViWkW8rbUIcjvoXC2Baf+F2zjTPX a/BjhtZH5EMNlnP9X86aHVSkOgM7lpkCrqwFYjr9CDuR2HNgoD6tbHn0kWmrjHvZ+9LW kq2tGr6GYSudUIBtQe0LXURfYcsv0fAG8xMRlWPLKebsV+fYLE/E9RDF53vs4hfXkR3e EeL28M7EVgvPajRiKIIyGm1ccPmg5MmW+hkGouZn7o41qmJ9/uRLj2qiLA474ZbkBrLl 7aQA== X-Gm-Message-State: ACrzQf2W6c/938qnkgVuWY7XzyZLDk6a42oysrWAdBqxbIF3LRW/zHX6 +95lcLbdD5jNTbZp0K0BV/M= X-Google-Smtp-Source: AMsMyM6kqo/xyRK2WN8cEuIDlr4HzUewT6m9UZiwn1PKn11BmXPY+fbdvD5h96LzvMmVE4+IIDv7dA== X-Received: by 2002:a05:600c:1c84:b0:3b3:ef37:afd3 with SMTP id k4-20020a05600c1c8400b003b3ef37afd3mr2220364wms.155.1665571841356; Wed, 12 Oct 2022 03:50:41 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id g10-20020a5d46ca000000b0022eafed36ebsm12617224wrs.73.2022.10.12.03.50.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 03:50:41 -0700 (PDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=2a00:1450:4864:20::335; envelope-from=raaahh@gmail.com; helo=mail-wm1-x335.google.com X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-2.934, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:297594 Archived-At: On 12.10.2022 09:37, Yuan Fu wrote: > If the user enables eglot, eglot sets menu-create-index-function to eglot-imenu, overriding major mode’s function. I suppose it does override that, but are you sure it's always a good idea? Are Imenu indexes produced by Eglot really better than what we can do with TreeSitter? IME it doesn't usually need project-wide information, since the menu is local to the current file. Some language servers could be smarter in the way that they recognize some framework-based patterns, which aren't inherent in the language. But the major modes can do that too.