From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#51497: 29.0.50; (vc-print-log) broken over TRAMP Date: Wed, 3 Nov 2021 05:00:49 +0300 Message-ID: <5744f091-a9d2-fdd8-43cf-cc94fb3fdbda@yandex.ru> References: <877ddv9ue0.fsf@jpl.nasa.gov> <87tugyptju.fsf@gnus.org> <87tugy8h3a.fsf@secretsauce.net> <87pmrl8yhy.fsf@secretsauce.net> <87r1c14njw.fsf@gmx.de> <87mtmp41tt.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30360"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 Cc: 51497@debbugs.gnu.org, Lars Ingebrigtsen , Dima Kogan , Wolfgang Scherer To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Nov 03 03:01:13 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mi5aT-0007o3-03 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 03 Nov 2021 03:01:13 +0100 Original-Received: from localhost ([::1]:44912 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mi5aR-00062t-Ol for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 02 Nov 2021 22:01:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53042) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mi5aI-00062l-F6 for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 22:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55150) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mi5aI-0005Yl-68 for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 22:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mi5aH-0002QZ-Qd for bug-gnu-emacs@gnu.org; Tue, 02 Nov 2021 22:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 03 Nov 2021 02:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51497 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo Original-Received: via spool by 51497-submit@debbugs.gnu.org id=B51497.16359048609316 (code B ref 51497); Wed, 03 Nov 2021 02:01:01 +0000 Original-Received: (at 51497) by debbugs.gnu.org; 3 Nov 2021 02:01:00 +0000 Original-Received: from localhost ([127.0.0.1]:38463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mi5aG-0002QC-0p for submit@debbugs.gnu.org; Tue, 02 Nov 2021 22:01:00 -0400 Original-Received: from mail-lf1-f44.google.com ([209.85.167.44]:35436) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mi5aD-0002Py-W7 for 51497@debbugs.gnu.org; Tue, 02 Nov 2021 22:00:58 -0400 Original-Received: by mail-lf1-f44.google.com with SMTP id p16so2175719lfa.2 for <51497@debbugs.gnu.org>; Tue, 02 Nov 2021 19:00:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TkmY7etZhnxzo2FB6zE5xrgTCLvmRUDho4qoISGwgog=; b=GZgmNsPfiEU1D6ZvGfpTMfCx6DQs0upiPdhOOVXanfUdR6k0RRECzeGPVoh+ahEbmO w5KpFJlmoNl8Eo33SE2tTzuRSoPx7ijnF5p6dkreUsocMxmDd31XCfZrv6utok7JVRQW 8F9EZyojpzbUpjAv+iRmITk1Q3j+VuNcGMxVW9MLA0RRZHC/aY7nFqTsOklwX19F46Rf /A47+SkrODKSle8RDqzukibhX2VKhpHebIlEdbxn4xP5D9DM84ZzyAAENavGpK7gAhjW OpiwC3Wb9DHajbIkpQgOHraPPi3HerfOk4OHY6ssO7IvxWbDJl2JLYjQzcqZeSt4zHXf t59g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TkmY7etZhnxzo2FB6zE5xrgTCLvmRUDho4qoISGwgog=; b=CBQaPTxcKVd+K8jZfi80ptS49D1ECszQMA17FH5+LTdslDdWqKPcKZ+MG4ngO8w+39 4Tdg0v7cLJvdKDp1Pm1HfnbumsbAPcrjK9xEncvXKbhaf+sYz6QhawIgxbHjiBYDTj+q OwphtyXGPQxHs1nrxY72TgEpAhqO2NT2Ley7XJ0R1xIke8b1RHNA+HPkp5RVmX9DbTaO C8l0icRluJ9JMW45iZiVyyRpHz69R9XGWVS6xR+cpGHUK/N3DCs6f4Lu/ycDJgBPnLtc 9tAZ+alPjB+Zb97prQP5m9xVN8nVV7XJ8M55yMW1J543Rs/RRhwUi24Tylz+R5ijgUGx DyQA== X-Gm-Message-State: AOAM533yBJsRXS/tmvsgnpJ+qV/+iNO3/6LkH8jC85sQAAcQFhFX/Y6h FxFUH+16yaqaDryR/W856lY= X-Google-Smtp-Source: ABdhPJyOnXr9AMvgjfKpxpiXgDWoqbJwFFnA/kqb76EPDE/GhdOeL3srof2hx9h9qD98A6UXTDRRoQ== X-Received: by 2002:ac2:4f02:: with SMTP id k2mr37996820lfr.455.1635904851848; Tue, 02 Nov 2021 19:00:51 -0700 (PDT) Original-Received: from [192.168.0.103] ([5.18.158.28]) by smtp.googlemail.com with ESMTPSA id e1sm66855ljf.73.2021.11.02.19.00.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Nov 2021 19:00:51 -0700 (PDT) In-Reply-To: <87mtmp41tt.fsf@gmx.de> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:218840 Archived-At: Hi Michael, On 31.10.2021 19:05, Michael Albinus wrote: > (defun vc-git--program-version () > (let ((current > (if (file-remote-p default-directory) > (with-connection-local-variables > (and (local-variable-p 'vc-git--program-version) > vc-git--program-version)) > vc-git--program-version))) > (or current > (let ((version-string > (vc-git--run-command-string nil "version"))) > (setq version-string > (if (and version-string > ;; Git for Windows appends ".windows.N" to the > ;; numerical version reported by Git. > (string-match > "git version \\([0-9.]+\\)\\(\\.windows\\.[0-9]+\\)?$" > version-string)) > (match-string 1 version-string) > "0")) > (if (file-remote-p default-directory) > (let ((profile (gensym "connection-local-profile-"))) > (connection-local-set-profile-variables > profile `((vc-git--program-version . ,version-string))) ; > (connection-local-set-profiles > (connection-local-criteria-for-default-directory) profile)) > (setq vc-git--program-version version-string)) > version-string)))) I wonder if we could have some helper that is more succinct. One that didn't require the client code to auto-generate the profile name, for instance.