From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional Date: Sat, 7 May 2016 17:21:45 -0700 Organization: UCLA Computer Science Department Message-ID: <572E8699.5090209@cs.ucla.edu> References: <572C3010.6080604@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------070000050909070707010008" X-Trace: ger.gmane.org 1462666941 25162 80.91.229.3 (8 May 2016 00:22:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 8 May 2016 00:22:21 +0000 (UTC) Cc: 22465@debbugs.gnu.org To: joakim@verona.se, Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 08 02:22:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1azCU5-0003Zz-Ac for geb-bug-gnu-emacs@m.gmane.org; Sun, 08 May 2016 02:22:09 +0200 Original-Received: from localhost ([::1]:35518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azCU4-0001un-4x for geb-bug-gnu-emacs@m.gmane.org; Sat, 07 May 2016 20:22:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33586) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azCU0-0001sD-7U for bug-gnu-emacs@gnu.org; Sat, 07 May 2016 20:22:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1azCTy-0001Pm-OX for bug-gnu-emacs@gnu.org; Sat, 07 May 2016 20:22:04 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:58896) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1azCTy-0001Pi-Lw for bug-gnu-emacs@gnu.org; Sat, 07 May 2016 20:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1azCTy-0003B6-FE for bug-gnu-emacs@gnu.org; Sat, 07 May 2016 20:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 08 May 2016 00:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22465 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22465-submit@debbugs.gnu.org id=B22465.146266691712206 (code B ref 22465); Sun, 08 May 2016 00:22:02 +0000 Original-Received: (at 22465) by debbugs.gnu.org; 8 May 2016 00:21:57 +0000 Original-Received: from localhost ([127.0.0.1]:43000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azCTt-0003An-1H for submit@debbugs.gnu.org; Sat, 07 May 2016 20:21:57 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53713) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1azCTq-0003AX-Gf for 22465@debbugs.gnu.org; Sat, 07 May 2016 20:21:56 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 11ED016120E; Sat, 7 May 2016 17:21:48 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id H1VAQhVpGpbE; Sat, 7 May 2016 17:21:46 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 7112A161210; Sat, 7 May 2016 17:21:46 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id mR6OOpmlvIrB; Sat, 7 May 2016 17:21:46 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 4274E16120E; Sat, 7 May 2016 17:21:46 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117971 Archived-At: This is a multi-part message in MIME format. --------------070000050909070707010008 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit joakim@verona.se wrote: > Perhaps someone still prefers the 'image method though. This seems unlikely, given that it recurses infinitely whenever it scrolls left or right. Anyway, thanks for following up. If nobody objects I would like to install the attached patch to emacs-25 to remove xwidget-webkit-scroll-behavior and therefore fix the bug. --------------070000050909070707010008 Content-Type: text/x-diff; name="0001-Remove-buggy-non-native-image-scrolling.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Remove-buggy-non-native-image-scrolling.patch" >From 58b7ecc4bcba46c775a7edca209587f034185861 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 7 May 2016 17:17:55 -0700 Subject: [PATCH] Remove buggy non-native image scrolling This never worked, and could cause infinite recursion. Problem reported by Glenn Morris (Bug#22465). * lisp/xwidget.el (xwidget-webkit-scroll-behavior): Remove. All uses removed. --- lisp/xwidget.el | 43 +++++++++---------------------------------- 1 file changed, 9 insertions(+), 34 deletions(-) diff --git a/lisp/xwidget.el b/lisp/xwidget.el index 19f631f..7a0ca8b 100644 --- a/lisp/xwidget.el +++ b/lisp/xwidget.el @@ -34,13 +34,6 @@ (require 'cl-lib) (require 'bookmark) -(defcustom xwidget-webkit-scroll-behavior 'native - "Scrolling behavior of the webkit instance. -The possible values are: `native' or `image'." - :version "25.1" - :group 'frames ; TODO add xwidgets group if more options are added - :type '(choice (const native) (const image))) - (declare-function make-xwidget "xwidget.c" (type title width height arguments &optional buffer)) (declare-function xwidget-set-adjustment "xwidget.c" @@ -141,40 +134,24 @@ xwidget-webkit-mode-map "Keymap for `xwidget-webkit-mode'.") (defun xwidget-webkit-scroll-up () - "Scroll webkit up. -Depending on the value of `xwidget-webkit-scroll-behavior', -this scrolls in `native' fashion, or like `image-mode' would." + "Scroll webkit up." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t 50) - (image-scroll-up))) + (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t 50)) (defun xwidget-webkit-scroll-down () - "Scroll webkit down. -Depending on the value of `xwidget-webkit-scroll-behavior', -this scrolls in `native' fashion, or like `image-mode' would." + "Scroll webkit down." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t -50) - (image-scroll-down))) + (xwidget-set-adjustment (xwidget-webkit-last-session) 'vertical t -50)) (defun xwidget-webkit-scroll-forward () - "Scroll webkit forwards. -Depending on the value of `xwidget-webkit-scroll-behavior', -this scrolls in `native' fashion, or like `image-mode' would." + "Scroll webkit forwards." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50) - (xwidget-webkit-scroll-forward))) ; FIXME infloop! + (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50)) (defun xwidget-webkit-scroll-backward () - "Scroll webkit backwards. -Depending on the value of `xwidget-webkit-scroll-behavior', -this scrolls in `native' fashion, or like `image-mode' would." + "Scroll webkit backwards." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50) - (xwidget-webkit-scroll-backward))) ; FIXME infloop! + (xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50)) ;; The xwidget event needs to go into a higher level handler @@ -417,9 +394,7 @@ xwidget-webkit-adjust-size-to-content (defun xwidget-webkit-adjust-size-dispatch () "Adjust size according to mode." (interactive) - (if (eq xwidget-webkit-scroll-behavior 'native) - (xwidget-webkit-adjust-size-to-window) - (xwidget-webkit-adjust-size-to-content)) + (xwidget-webkit-adjust-size-to-window) ;; The recenter is intended to correct a visual glitch. ;; It errors out if the buffer isn't visible, but then we don't get ;; the glitch, so silence errors. -- 2.7.4 --------------070000050909070707010008--