From: Paul Eggert <eggert@cs.ucla.edu>
To: Glenn Morris <rgm@gnu.org>
Cc: 22465@debbugs.gnu.org
Subject: bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional
Date: Thu, 5 May 2016 22:48:00 -0700 [thread overview]
Message-ID: <572C3010.6080604@cs.ucla.edu> (raw)
In-Reply-To: <g98u3dl012.fsf@fencepost.gnu.org>
[-- Attachment #1: Type: text/plain, Size: 81 bytes --]
Attached is a proposed patch for this bug. It is not fancy, but it works for me.
[-- Attachment #2: 0001-Fix-xwidget-webkit-scroll-forward-infloop.fix --]
[-- Type: text/plain, Size: 1395 bytes --]
From 879895ad058294eb49d8372ef5dbf053973e45b9 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Thu, 5 May 2016 22:44:16 -0700
Subject: [PATCH] Fix xwidget-webkit-scroll-forward infloop
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* lisp/xwidget.el (xwidget-webkit-scroll-forward)
(xwidget-webkit-scroll-backward): Don’t loop if
xwidget-webkit-scroll-behavior’s value is ‘image’ (Bug#22465).
---
lisp/xwidget.el | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lisp/xwidget.el b/lisp/xwidget.el
index 19f631f..d64237a 100644
--- a/lisp/xwidget.el
+++ b/lisp/xwidget.el
@@ -165,7 +165,7 @@ xwidget-webkit-scroll-forward
(interactive)
(if (eq xwidget-webkit-scroll-behavior 'native)
(xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t 50)
- (xwidget-webkit-scroll-forward))) ; FIXME infloop!
+ (image-forward-hscroll 5)))
(defun xwidget-webkit-scroll-backward ()
"Scroll webkit backwards.
@@ -174,7 +174,7 @@ xwidget-webkit-scroll-backward
(interactive)
(if (eq xwidget-webkit-scroll-behavior 'native)
(xwidget-set-adjustment (xwidget-webkit-last-session) 'horizontal t -50)
- (xwidget-webkit-scroll-backward))) ; FIXME infloop!
+ (image-backward-hscroll 5)))
;; The xwidget event needs to go into a higher level handler
--
2.7.4
next prev parent reply other threads:[~2016-05-06 5:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 23:19 bug#22465: xwidget-webkit-scroll-behaviour = image is non-functional Glenn Morris
2016-05-06 5:48 ` Paul Eggert [this message]
2016-05-06 15:42 ` Glenn Morris
2016-05-06 17:50 ` joakim
2016-05-08 0:21 ` Paul Eggert
2016-05-13 8:05 ` joakim
2016-05-13 16:53 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572C3010.6080604@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=22465@debbugs.gnu.org \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.