From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' Date: Mon, 02 May 2016 10:00:17 +0200 Message-ID: <57270911.8010309@gmx.at> References: <05342534-126d-44f4-b415-3159c44740f1@default> <83bnig4mav.fsf@gnu.org> <55376B18.5090103@gmx.at> <838udk4fx7.fsf@gnu.org> <5538A449.6010308@gmx.at> <83vbgn1677.fsf@gnu.org> <55449178.8020309@gmx.at> <55463900.6090709@gmx.at> <87inyzdk8e.fsf@gnus.org> <5725BD16.6020900@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1462176102 13004 80.91.229.3 (2 May 2016 08:01:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 2 May 2016 08:01:42 +0000 (UTC) Cc: 20398@debbugs.gnu.org, Lars Ingebrigtsen To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 02 10:01:31 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ax8nJ-0001PP-SZ for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 May 2016 10:01:30 +0200 Original-Received: from localhost ([::1]:35620 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ax8nG-0001mI-5S for geb-bug-gnu-emacs@m.gmane.org; Mon, 02 May 2016 04:01:26 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ax8n8-0001cK-AU for bug-gnu-emacs@gnu.org; Mon, 02 May 2016 04:01:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ax8mw-0000dr-A5 for bug-gnu-emacs@gnu.org; Mon, 02 May 2016 04:01:12 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:48884) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ax8mw-0000cj-63 for bug-gnu-emacs@gnu.org; Mon, 02 May 2016 04:01:06 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ax8ms-0005j7-HX for bug-gnu-emacs@gnu.org; Mon, 02 May 2016 04:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 02 May 2016 08:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20398-submit@debbugs.gnu.org id=B20398.146217604121979 (code B ref 20398); Mon, 02 May 2016 08:01:02 +0000 Original-Received: (at 20398) by debbugs.gnu.org; 2 May 2016 08:00:41 +0000 Original-Received: from localhost ([127.0.0.1]:32988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ax8mX-0005iR-7g for submit@debbugs.gnu.org; Mon, 02 May 2016 04:00:41 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:53675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ax8mW-0005iF-3F for 20398@debbugs.gnu.org; Mon, 02 May 2016 04:00:40 -0400 Original-Received: from [192.168.1.101] ([212.95.7.50]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0LejNC-1bSfya2oGc-00qQuB; Mon, 02 May 2016 10:00:30 +0200 In-Reply-To: X-Provags-ID: V03:K0:FFxCtH6nQfKzezpIbMnNZLzNFvqeOqBgEphyc/uzk7pRLlTN3Lj JwVoCuIpXKRCbjETYC+5/CLLsL2EEfTj76n4D7O6z2jnyOuSOKaADcNMqYcOtWWgGwoagqV t/2iIHZcF5lHMRFv6slVQRzezFVU+5wK+iYaQQCx9HOg+1KDENb6I8BZ2T6GK/wobwsZu21 JlAbcgAIbRmNFa4CYPNWQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:iSsQWeLMQ2U=:g6sq2P0pD21xF450R8bzml K7J1qGBHKav4gFPBnWQg8y9Fy5/HfkveHD1ANd0+gPZzG9HcT7GBRFT9I1+ukRcjdaim/orta JujkxdMOzyrUugqprmkmUE4Zdao5RUM/KJ1fbFELVRil8MrCtJUsXf2HLBp4ud5XPwyQJXM32 snawea373WPu3ZAL0cZR0tPwOvC6oBvr9HfZhUnY5ZMq7g9TVmdBknal4/2XNahw9lgs5v6wK jLy5JZk6PeVpCy6elcLhX0+iCyukw4Ee8leQEvv7RtcQx4+/sK2bjhPxRk+FxTieAFVqLHGt7 H4MaxTMd/zzt7KjMvqVz23WLHRASZyDDrtw+otQhEpECidZzE1Z6ABftZlieKa20XN52x5v+K 1YX/0pABLr6FqD0Jv2t5M5Nb9ixafJU77PYaa3gEFc2r4g+bu+H07uwi3fiEU8SvpyB00YrmF wowego0pOkrCKAb81Du5NPhsffCZB04/CyjAr+h3+dyqN7l8BK3+Vw4xiabAPwLu8ggwIEmGt V5IdRESZDtu8RMoXV7BNY1kcTvbJItBf8Q9GHqSO/isBWMJ7cFRUjtDiekC4zzY4VTK/pRee+ 3vu1Fy91ybI4sAxjkxTbKmQAnJhk/IjrHBWAbYIwSkIPl/l88oApF4rNTllC/vHNKay8QVrVG 67gM8ROBgkJfoACKFbF35P+PUmPbVGKFPWnG5YjxcoDGm08+1ZPc/70HAQnbTC6Pc6YJw9V3J ttEULNwQVS+uCOM660ISkIM0meErN2pVyR2/fIFQPNdVOx3zNi8nxx/QcbMKLgxUnzGx5h8s X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:117557 Archived-At: >> Shouldn't we then do the same here: >>>>>> (define-key map [down-mouse-1] 'widget-button-click) > > I think so, yes. So the patch is as below. Any objections to apply this to the emacs-25 branch? martin diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el index f0054be..0a0f458 100644 --- a/lisp/wid-edit.el +++ b/lisp/wid-edit.el @@ -852,8 +852,8 @@ widget-keymap (define-key map [(shift tab)] 'widget-backward) (put 'widget-backward :advertised-binding [(shift tab)]) (define-key map [backtab] 'widget-backward) - (define-key map [down-mouse-2] 'widget-button-click) - (define-key map [down-mouse-1] 'widget-button-click) + (define-key map [mouse-2] 'widget-button-click) + (define-key map [mouse-1] 'widget-button-click) ;; The following definition needs to avoid using escape sequences that ;; might get converted to ^M when building loaddefs.el (define-key map [(control ?m)] 'widget-button-press)