From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: 20398@debbugs.gnu.org, Lars Ingebrigtsen <larsi@gnus.org>
Subject: bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider'
Date: Mon, 02 May 2016 10:00:17 +0200 [thread overview]
Message-ID: <57270911.8010309@gmx.at> (raw)
In-Reply-To: <jwvtwih3opz.fsf-monnier+emacsbugs@gnu.org>
>> Shouldn't we then do the same here:
>>>>>> (define-key map [down-mouse-1] 'widget-button-click)
>
> I think so, yes.
So the patch is as below. Any objections to apply this to the emacs-25
branch?
martin
diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
index f0054be..0a0f458 100644
--- a/lisp/wid-edit.el
+++ b/lisp/wid-edit.el
@@ -852,8 +852,8 @@ widget-keymap
(define-key map [(shift tab)] 'widget-backward)
(put 'widget-backward :advertised-binding [(shift tab)])
(define-key map [backtab] 'widget-backward)
- (define-key map [down-mouse-2] 'widget-button-click)
- (define-key map [down-mouse-1] 'widget-button-click)
+ (define-key map [mouse-2] 'widget-button-click)
+ (define-key map [mouse-1] 'widget-button-click)
;; The following definition needs to avoid using escape sequences that
;; might get converted to ^M when building loaddefs.el
(define-key map [(control ?m)] 'widget-button-press)
next prev parent reply other threads:[~2016-05-02 8:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 20:02 bug#20398: 25.0.50; Clicking `window-divider-last-pixel' in help for `window-divider' Drew Adams
2015-04-22 8:08 ` Eli Zaretskii
2015-04-22 9:34 ` martin rudalics
2015-04-22 10:26 ` Eli Zaretskii
2015-04-22 22:50 ` Glenn Morris
2015-04-23 7:50 ` martin rudalics
2015-04-23 10:37 ` Eli Zaretskii
2015-05-02 8:57 ` martin rudalics
2015-05-02 9:09 ` Eli Zaretskii
2015-05-03 5:42 ` Stefan Monnier
2015-05-03 15:04 ` martin rudalics
2015-05-04 1:56 ` Stefan Monnier
2016-04-30 18:28 ` Lars Ingebrigtsen
2016-04-30 18:51 ` Stefan Monnier
2016-04-30 19:27 ` Stefan Monnier
2016-05-01 8:23 ` martin rudalics
2016-05-01 13:15 ` Stefan Monnier
2016-05-02 8:00 ` martin rudalics [this message]
2016-05-02 17:13 ` Lars Ingebrigtsen
2016-05-03 6:44 ` martin rudalics
2016-05-03 16:42 ` Stefan Monnier
2016-05-01 8:23 ` martin rudalics
[not found] <<05342534-126d-44f4-b415-3159c44740f1@default>
[not found] ` <<83bnig4mav.fsf@gnu.org>
[not found] ` <<55376B18.5090103@gmx.at>
[not found] ` <<838udk4fx7.fsf@gnu.org>
2015-04-22 13:42 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=57270911.8010309@gmx.at \
--to=rudalics@gmx.at \
--cc=20398@debbugs.gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.