From: martin rudalics <rudalics@gmx.at>
To: Alan Third <alan@idiocy.org>, 22660@debbugs.gnu.org
Subject: bug#22660: [PATCH] Implement horizontal scroll-bars in NS port
Date: Thu, 28 Apr 2016 08:33:29 +0200 [thread overview]
Message-ID: <5721AEB9.4070509@gmx.at> (raw)
In-Reply-To: <20160427202031.GA46548@breton.local>
> My attempt at enabling horizontal scroll-bars in the NS port. This
> patch also removes the custom NS scroll-bar handlers in favour of the
> standard ones. I think this *may* cause behaviour of the vertical
> scroll-bars to change slightly.
>
> I've tried to clean up some of the code as there were a few places
> where it didn't make a whole lot of sense to me. I guess that's due to
> the code I started with being a partial implementation.
Thank you. With the limited testing capabilities of GNUStep it seems to
work. Or better: If everything in the GNUStep worked as well as your
patch, the GNUStep port might even become usable one day ;-)
There is one aspect which might be part of the design but appears
nevertheless distracting for somone working mainly on other platforms:
When the entire buffer is visible, no sliders/rulers are shown. Now,
some people want that in this case the scrollbar area(s) get removed
completely. Personally, I'd prefer the sliders/ruler cover the entire
scroll bar area with the arrows possibly removed. But maybe the current
behavior (which is so here ever since for the vertical case) is standard
on NS so don't let my remarks distract you.
Personally, I'd vote for including this in Emacs-25. It's a completely
self-confined, local patch and we could avoid answering questions like
"why don't these work on Macs" after the forthcoming release.
In any case, many thanks for the accomplishment, martin
next prev parent reply other threads:[~2016-04-28 6:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-14 11:04 bug#22660: No horizontal scroll bars in NextStep build [OSX] Angelo Graziosi
2016-02-14 12:20 ` Alan Third
2016-02-14 15:33 ` Angelo Graziosi
2016-02-15 10:57 ` martin rudalics
2016-02-15 17:48 ` Alan Third
2016-04-27 20:20 ` bug#22660: [PATCH] Implement horizontal scroll-bars in NS port Alan Third
2016-04-28 6:33 ` martin rudalics [this message]
2016-04-28 9:16 ` Alan Third
2016-04-28 19:00 ` Alan Third
2016-04-29 8:36 ` martin rudalics
2016-04-30 15:35 ` Alan Third
2016-04-30 20:53 ` bug#22660: [PATCH v2] " Alan Third
2016-05-01 8:24 ` martin rudalics
2016-05-01 8:50 ` Alan Third
2016-05-01 11:08 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5721AEB9.4070509@gmx.at \
--to=rudalics@gmx.at \
--cc=22660@debbugs.gnu.org \
--cc=alan@idiocy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.