From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#43702: Emacs master: Incorrect highlighting in regexp isearch. Date: Tue, 13 Oct 2020 13:54:57 -0700 (PDT) Message-ID: <5720d2bb-ba33-4e27-8d56-39888861f044@default> References: <20200929121317.GA27007@ACM> <83wo0ck5ig.fsf@gnu.org> <20200929153355.GB27007@ACM> <87y2ks819k.fsf@gnus.org> <87y2krdqsk.fsf@mail.linkov.net> <87y2kp93dn.fsf@mail.linkov.net> <87mu0z3zxf.fsf@mail.linkov.net> <871riav4os.fsf@mail.linkov.net> <21c5738b-e9f2-465f-9ca3-8947a5b9191d@default> <874kmzz03q.fsf@mail.linkov.net> <871ri1g9yu.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28783"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Alan Mackenzie , Lars Ingebrigtsen , 43702@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Oct 13 22:56:22 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kSRLI-0007Mg-U0 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 22:56:20 +0200 Original-Received: from localhost ([::1]:43186 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kSRLH-0003wy-WE for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 13 Oct 2020 16:56:20 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:34536) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kSRL0-0003vV-6U for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 16:56:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37525) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kSRKz-0003w3-Rl for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 16:56:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kSRKz-00037u-Pw for bug-gnu-emacs@gnu.org; Tue, 13 Oct 2020 16:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Oct 2020 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43702 X-GNU-PR-Package: emacs Original-Received: via spool by 43702-submit@debbugs.gnu.org id=B43702.160262250911939 (code B ref 43702); Tue, 13 Oct 2020 20:56:01 +0000 Original-Received: (at 43702) by debbugs.gnu.org; 13 Oct 2020 20:55:09 +0000 Original-Received: from localhost ([127.0.0.1]:49071 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSRK8-00036V-Qv for submit@debbugs.gnu.org; Tue, 13 Oct 2020 16:55:09 -0400 Original-Received: from userp2120.oracle.com ([156.151.31.85]:48268) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kSRK5-00035q-VQ for 43702@debbugs.gnu.org; Tue, 13 Oct 2020 16:55:07 -0400 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09DKrlIu093853; Tue, 13 Oct 2020 20:55:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=zo14Ardb3Ob+Z5Zfe+1TV6N4nt+yWPl70Oqw7sUWzx8=; b=ONDLUMPxwUAUUslj0dhFfkGALrzH8TVUCY0oSe07a+s38e89UsRU8hV6s8Hl9s1aLIfY W/BL55I0RJ3K9HIr8e+6k36LcbJJIALc54TIWcInR/pAJerBYLG47jbOVYTk6jMOF3bs XcgnTb7/OAXD89zWSow9FAj+tKRMJgih8MwiMqQU/9EXjQQfcM4A9M5RHXE8g2vPH7zj rrNcXv1gBC/MmEofME33Dxuz5jb4rkwYnSc5pqviIdo/QSu2cu6aefxZQR/7jFeSinaJ 4YCX3ICs1bPNeWeyOs5S82CGEg/S7yfJHCfO1rRFTbst1CqTtUBFNMySUGDDz1TMjHqC PQ== Original-Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by userp2120.oracle.com with ESMTP id 343vaeaqqb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 13 Oct 2020 20:55:00 +0000 Original-Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09DKsZoP189348; Tue, 13 Oct 2020 20:54:59 GMT Original-Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 343pvwxa5c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 13 Oct 2020 20:54:59 +0000 Original-Received: from abhmp0020.oracle.com (abhmp0020.oracle.com [141.146.116.26]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 09DKswJJ015801; Tue, 13 Oct 2020 20:54:58 GMT In-Reply-To: <871ri1g9yu.fsf@mail.linkov.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9773 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxscore=0 adultscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010130149 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9773 signatures=668681 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 clxscore=1015 impostorscore=0 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 mlxscore=0 suspectscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010130149 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:190455 Archived-At: > > I don't understand why you change the signature of > > `replace-highlight' by adding parameter MATCH-DATA. > > > > I just use (match-beginning GROUP) and (match-end GROUP), > > instead of explicitly passing the match data and then > > copying it all with `butlast' etc. just to find the > > group's match beginning and end. >=20 > But as you can see in the patch, it doesn't use (match-data). > It uses the variable 'real-match-data'. Yes, I saw that. I suppose it must be relevant, but it's not clear to me why. I haven't noticed any problem with just using the latest match data, but I haven't tested much. It would be good to add a code comment to cite a case or specify the cases where it matters. Thx.