From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nikolay Kudryavtsev Newsgroups: gmane.emacs.bugs Subject: bug#23076: 24.5; vc-git: add a new variable for log output coding system Date: Sat, 9 Apr 2016 15:30:02 +0300 Message-ID: <5708F5CA.3080509@gmail.com> References: <56EFE033.7080900@gmail.com> <56F04527.6010901@gmail.com> <83fuv4s4cr.fsf@gnu.org> <57017E45.7050605@gmail.com> <83pou5o0uh.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1460205076 27250 80.91.229.3 (9 Apr 2016 12:31:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Apr 2016 12:31:16 +0000 (UTC) Cc: 23076@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 09 14:31:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aos2f-0001ip-Rw for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2016 14:31:10 +0200 Original-Received: from localhost ([::1]:60226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aos2e-0004gy-Tz for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Apr 2016 08:31:08 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35077) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aos2b-0004er-AZ for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 08:31:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aos2Y-00038J-2m for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 08:31:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:42899) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aos2X-00038F-WD for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 08:31:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aos2X-0003si-Kf for bug-gnu-emacs@gnu.org; Sat, 09 Apr 2016 08:31:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nikolay Kudryavtsev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Apr 2016 12:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23076 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23076-submit@debbugs.gnu.org id=B23076.146020501314866 (code B ref 23076); Sat, 09 Apr 2016 12:31:01 +0000 Original-Received: (at 23076) by debbugs.gnu.org; 9 Apr 2016 12:30:13 +0000 Original-Received: from localhost ([127.0.0.1]:55236 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aos1l-0003ri-1J for submit@debbugs.gnu.org; Sat, 09 Apr 2016 08:30:13 -0400 Original-Received: from mail-lf0-f68.google.com ([209.85.215.68]:35229) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aos1j-0003rV-DG for 23076@debbugs.gnu.org; Sat, 09 Apr 2016 08:30:11 -0400 Original-Received: by mail-lf0-f68.google.com with SMTP id o124so13381153lfb.2 for <23076@debbugs.gnu.org>; Sat, 09 Apr 2016 05:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=crAIpUsn5BRlP69JWcGugOA4ZRfys9ETwcrIu9d6qOc=; b=Ssh49fX1+GjJzALFn3R+r/OU0UB1fYPO6anMQjfZiTLfd8iAYCcwJd57rZlGyexV2Z FyBwO5OVGjiVLqbUDszk7dSpFKI3tUeiz/iHf/pTvWpJsLobSjkzF1rDFXRG9x097OIj z41aLQDrc6zScwXMq0sz6kcuYg/j5oRh4qOGljzNJEZTCp7NhFfw58Bv3xrOoip1k24F lKfv4yZT/nDZ97pbrEqQgarLb/5WRqNBSr8FCX+EPUANDJIVjlWRISqRx2TFOWJhkPuJ AaS3SkJkAPuuj3Rs1X2qt6bcCBu+w3UuP1Bm9D0mAMlQCGoQ6yCTDTa0dRG45eQh7avu lYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=crAIpUsn5BRlP69JWcGugOA4ZRfys9ETwcrIu9d6qOc=; b=cQf8qLJZtG29CernS02JqypKL5Hfdc9oLUD1iLq0kc6XVQ9qxcGYW4vSTN7zQ/ehCn lqK85P/PkWG0aarLRx+bZKzu7hiry7PA6iVB2/jQ4+gnQcrLgKMz0ynU27C6qgHr/byF AwvcJtVfHL8Y5YyQ5RGH0nrLbu9o18MhiYQ9WqKtmX0YO2wqJfZdl+kzEWDCUiD4XWwq d3qdgzu9tZicg9fysnBHNAHCC4itPVKXc9fKD74WT3c+7E5Y3pCL/6ohmLo9a3IQbIJV kIr1uFV7HxjyIUrNkpYZAejIT7QmR1Ghr9j1nfYs8jxnuR1dmykPf3l6jC6w1pDqi/TB kg3A== X-Gm-Message-State: AD7BkJICBmVWWgavi6a5qF0Xc44LWUI9/Gf/m575uSWQD0iUuunxMqav1+KMR/7BGZQu9A== X-Received: by 10.112.56.43 with SMTP id x11mr5300561lbp.145.1460205005384; Sat, 09 Apr 2016 05:30:05 -0700 (PDT) Original-Received: from [192.168.199.2] (broadband-95-84-209-126.nationalcablenetworks.ru. [95.84.209.126]) by smtp.gmail.com with ESMTPSA id n184sm2770030lfb.37.2016.04.09.05.30.04 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 09 Apr 2016 05:30:04 -0700 (PDT) X-Google-Original-From: Nikolay Kudryavtsev User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.7.2 In-Reply-To: <83pou5o0uh.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:116271 Archived-At: My suggestion was based on the idea that introducing a new variable is guaranteed to not break anyone's setup. Solution 1 seems to be more dangerous in this regard. Also #1 seems inferior to #2 for this case - what if you don't have control over system non-Unicode encoding? Let's say someone wants to commit org-mode notes in his native language, from a workplace, where he has no admin rights for the machine and no ability to change that windows setting. That's probably a rare case, but still, seems like something that may happen. I also did some testing of #2 and noted this thing - the current git behaves somewhat weirdly in regards with git commitencoding and message files. That is: 1. Let's say your message.txt is encoded in windows-1251. Trying to commit it with "git commit -F message.txt" would result in a broken commit and this: > Warning: commit message did not conform to UTF-8. > You may want to amend it after fixing the message, or set the config > variable i18n.commitencoding to the encoding your project uses. 2. Let's try doing so and set commitencoding to windows-1251 and commit again. Now we get no warning, but our message is a badly coded mess, though differently from the previous step, so it did something extra while encoding the message. 3. Even when our commitencoding = windows-1251 committing message.txt in utf-8 works fine. So, it seems like we want to always use utf-8 for messages. -- Best Regards, Nikolay Kudryavtsev