From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: -Wall Date: Mon, 4 Apr 2016 11:51:53 -0700 Organization: UCLA Computer Science Department Message-ID: <5702B7C9.6010805@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1459795933 25662 80.91.229.3 (4 Apr 2016 18:52:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 4 Apr 2016 18:52:13 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Apr 04 20:52:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1an9bZ-0006TT-4E for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2016 20:52:05 +0200 Original-Received: from localhost ([::1]:60573 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an9bY-0005tm-Ji for ged-emacs-devel@m.gmane.org; Mon, 04 Apr 2016 14:52:04 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35304) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an9bU-0005tH-Vu for emacs-devel@gnu.org; Mon, 04 Apr 2016 14:52:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1an9bP-0003OS-Ti for emacs-devel@gnu.org; Mon, 04 Apr 2016 14:52:00 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40109) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1an9bP-0003N5-Ng for emacs-devel@gnu.org; Mon, 04 Apr 2016 14:51:55 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 5D8A4160068 for ; Mon, 4 Apr 2016 11:51:54 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kXqjRMefD5dq for ; Mon, 4 Apr 2016 11:51:53 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A871816125A for ; Mon, 4 Apr 2016 11:51:53 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id njp2T7kdYKd6 for ; Mon, 4 Apr 2016 11:51:53 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 8E6C6160068 for ; Mon, 4 Apr 2016 11:51:53 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202702 Archived-At: On 04/04/2016 11:22 AM, Lars Magne Ingebrigtsen wrote: > There's a lot fewer warnings when compiling with -Wall in emacs/src now > than there used to be, but there should be none, I think. I'm getting no warnings when I build. > Are there any of them that, like, are there for a reason (i.e., we > disagree with the gcc people that those things should be warned about), > or are they all things that should be fixed? > It's more the other way around: -Wall doesn't generate enough warnings. Please try './configure --enable-gcc-warnings'. This uses -Wall plus some other warning flags that are useful in practice. I regularly check that this builds cleanly for recent GCC on my platform (Fedora 23, GCC 5.3.1 20151207 (Red Hat 5.3.1-2)), and occasionally for recent Ubuntu, both using default configure-time options. If you'd like to take up the burden of porting --enable-gcc-warnings to other platforms feel free, though my suggestion is to not bother with older and/or rarely-used platforms as they have too many bugs in this area.