From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] src/print.c: Check for __GLIBC__ rather than GNU_LINUX Date: Sun, 3 Apr 2016 01:24:51 -0700 Organization: UCLA Computer Science Department Message-ID: <5700D353.40107@cs.ucla.edu> References: <1459315328-3663-1-git-send-email-somasissounds@gmail.com> <56FD8A8B.3040808@cs.ucla.edu> <83shz5u8vs.fsf@gnu.org> <56FE276C.2050306@cs.ucla.edu> <83pou8s90i.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1459671931 3970 80.91.229.3 (3 Apr 2016 08:25:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 Apr 2016 08:25:31 +0000 (UTC) Cc: emacs-devel@gnu.org, somasis@exherbo.org, somasissounds@gmail.com To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Apr 03 10:25:22 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1amdLV-0008RV-Qq for ged-emacs-devel@m.gmane.org; Sun, 03 Apr 2016 10:25:21 +0200 Original-Received: from localhost ([::1]:52494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amdLR-0003pV-JH for ged-emacs-devel@m.gmane.org; Sun, 03 Apr 2016 04:25:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amdLO-0003pQ-GX for emacs-devel@gnu.org; Sun, 03 Apr 2016 04:25:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1amdLN-0004XB-QJ for emacs-devel@gnu.org; Sun, 03 Apr 2016 04:25:14 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:47071) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1amdLJ-0004Wu-Cy; Sun, 03 Apr 2016 04:25:09 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id C95B8161244; Sun, 3 Apr 2016 01:25:07 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 7i_ghJhp17uA; Sun, 3 Apr 2016 01:25:07 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 10342161245; Sun, 3 Apr 2016 01:25:07 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Zpr5g1J-DTsA; Sun, 3 Apr 2016 01:25:06 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D72E2161244; Sun, 3 Apr 2016 01:25:06 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 In-Reply-To: <83pou8s90i.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202609 Archived-At: Eli Zaretskii wrote: > Are we sure fileno(stdin) will necessarily return 0, what with all the > redirections and stuff? Yes. The redirections in Emacs don't change the file descriptor numbers associated with stdin, stdout, and stderr. They will always be 0, 1, and 2. > Why not keep the original code? It's a bit slower, and (more important) it leads the reader to wonder whether fileno (stdin) might not equal STDIN_FILENO.