From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#55163: 29.0.50; master 4a1f69ebca (TICKS . HZ) for current-time broke lsp-mode Date: Sat, 30 Apr 2022 13:51:24 -0700 Organization: UCLA Computer Science Department Message-ID: <56e6d32c-7583-dbd9-85ee-e43d32a6feb1@cs.ucla.edu> References: <87sfpxxyvb.fsf@3-191.divsi.unimi.it> <87zgk5jtm6.fsf@gnus.org> <87o80kj2q1.fsf@gnus.org> <878rroi5a8.fsf@gnus.org> <83y1zo9n3o.fsf@gnu.org> <87y1zof944.fsf@gnus.org> <83wnf89mcj.fsf@gnu.org> <0a39a220-6298-8ed4-87bd-414702cd9b57@cs.ucla.edu> <83ee1facp0.fsf@gnu.org> <87tuab543p.fsf@gnus.org> <83pmky99hm.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33735"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Cc: Lars Ingebrigtsen , v.pupillo@gmail.com, 55163@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 30 22:52:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nku4c-0008e0-4J for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Apr 2022 22:52:14 +0200 Original-Received: from localhost ([::1]:45418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nku4a-0000Rg-KZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 30 Apr 2022 16:52:12 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52920) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nku4Q-0000Pq-Ag for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2022 16:52:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:37019) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nku4Q-0006Bo-12 for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2022 16:52:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nku4P-0005aj-So for bug-gnu-emacs@gnu.org; Sat, 30 Apr 2022 16:52:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 30 Apr 2022 20:52:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55163 X-GNU-PR-Package: emacs Original-Received: via spool by 55163-submit@debbugs.gnu.org id=B55163.165135189421455 (code B ref 55163); Sat, 30 Apr 2022 20:52:01 +0000 Original-Received: (at 55163) by debbugs.gnu.org; 30 Apr 2022 20:51:34 +0000 Original-Received: from localhost ([127.0.0.1]:59149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nku3y-0005Zz-Fy for submit@debbugs.gnu.org; Sat, 30 Apr 2022 16:51:34 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:36228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nku3x-0005Zl-Bt for 55163@debbugs.gnu.org; Sat, 30 Apr 2022 16:51:33 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id B71E21600C2; Sat, 30 Apr 2022 13:51:26 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id ProwfvsPsoRI; Sat, 30 Apr 2022 13:51:25 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 934FC1600D1; Sat, 30 Apr 2022 13:51:25 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id HJU1eDPzdSwZ; Sat, 30 Apr 2022 13:51:25 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 151D31600C2; Sat, 30 Apr 2022 13:51:25 -0700 (PDT) Content-Language: en-US In-Reply-To: <83pmky99hm.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:231075 Archived-At: On 4/30/22 03:00, Eli Zaretskii wrote: > That might mean we want a primitive that returns a list of files > sorted by modtime Such a primitive would not be as useful. First, it's common for Emacs to look at files opportunistically: that is, Emacs doesn't know in advance all the files it will eventually look at, and so it can't give a primitive a list of files in advance. Second, it's common for Emacs to compare the timestamp of a file at time T1 with the timestamp of another (or the same) file at a later time T2. A primitive that accepts a list of files can't do that. In contrast, a primitive that simply gives you a file's timestamp handles these use cases, and is considerably easier to describe and support. > we > will risk adding gobs of new APIs that rarely if ever used in > practice Yes, we don't want to do that. However the case for making improvements here is strong enough here that it's worth doing. There are dozens of potential uses for the proposed (file-attributes FILE 'mtime) etc. improvement in Emacs right now, so it's an easy call that this API will get used. There are also cases where the code now uses current-time and assumes that the resulting timestamps are issued in numeric order, an assumption that is not always true in practice. It'd be better for this code to use a monotonic clock instead. Admittedly the resulting misbehavior is rare (because it's rare that people adjust their machines' clocks), but Emacs shouldn't glitch out on me merely because I've corrected my laptop's time-of-day.