From: Paul Eggert <eggert@cs.ucla.edu>
To: Kaushal Modi <kaushal.modi@gmail.com>,
Emacs developers <emacs-devel@gnu.org>,
Alan Mackenzie <acm@muc.de>
Subject: Re: Understanding a recent commit in emacs-25 branch [ed19f2]
Date: Thu, 31 Mar 2016 23:43:14 -0700 [thread overview]
Message-ID: <56FE1882.9030904@cs.ucla.edu> (raw)
In-Reply-To: <CAFyQvY1c1FvSOyNk_OxbSP5-prM-mXoMekFNRrbsUC0V=3xubA@mail.gmail.com>
Kaushal Modi wrote:
> OK, I think I need some git education.
>
> There was one section in your commit (
> http://git.savannah.gnu.org/cgit/emacs.git/diff/lisp/isearch.el?h=emacs-25&id=ed19f207449c43f7f08285ada87ae7a46c61c8d1
> ) which was already committed earlier (
> http://git.savannah.gnu.org/cgit/emacs.git/commit/lisp/isearch.el?h=emacs-25&id=91e667692ba1362ca1334b8d58fd16c305ad5e2a
> ). As I am familiar with that single commit, I know that they are identical.
>
> Also I noted that your commit has a repeat of all the backquote/straight
> quote changes in NEWS that happened recently.
>
> But without this prior knowledge, how can one separate these duplicate
> commits from the commits that actually are new?
> Also, what is the reason for such duplicate commits happening?
There aren't any duplicate commits.
When you visit
http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=emacs-25&id=ed19f207449c43f7f08285ada87ae7a46c61c8d1
the website shows you the output of this command:
git diff
ed19f207449c43f7f08285ada87ae7a46c61c8d1^..ed19f207449c43f7f08285ada87ae7a46c61c8d1
The commit ed19f207449c43f7f08285ada87ae7a46c61c8d1 is a merge with two parents:
commits eabd667a9584fe5bd2422e296d256dceea67debf (which is a single incomplete
fix for cc-mode) and 7c1802f6ffc2704ba8042c7c1c6faa73dfa210d1 (which is the main
thread of the emacs-25 branch). The way Alan merged, the former commit is the
first parent, so the abovementioned diff output looks large -- it contains many
emacs-25 changes all squashed together. It might have been nicer if Alan had
merged the other way, so that that the main thread was the first parent, but
that's water under the bridge now. (In this particular case I would have avoided
a merge entirely, and would have rebased instead, as that makes such changes
easier for others to follow later; but that's also water under the bridge.)
Understanding what happened is somewhat complicated by the more-recent commit
22443312188ff097b69d9ff4b87c2b4f7bbbc263, which finished fixing the cc-mode
patch and undid some of the effect of the incomplete fix.
You can see all this more easily by running the shell command "gitk" in a
directory containing a checked-out copy of the emacs-25 branch.
next prev parent reply other threads:[~2016-04-01 6:43 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-01 5:32 Understanding a recent commit in emacs-25 branch [ed19f2] Kaushal Modi
2016-04-01 5:43 ` Kaushal Modi
2016-04-01 6:43 ` Paul Eggert [this message]
2016-04-03 12:03 ` Alan Mackenzie
2016-04-03 12:10 ` Achim Gratz
2016-04-03 14:18 ` Stefan Monnier
2016-04-03 14:49 ` Óscar Fuentes
2016-04-03 18:15 ` Achim Gratz
2016-04-03 18:45 ` Andreas Schwab
2016-04-03 18:56 ` Eli Zaretskii
2016-04-03 20:02 ` Paul Eggert
2016-04-03 21:15 ` Andreas Schwab
2016-04-03 23:11 ` John Wiegley
2016-04-03 12:18 ` Ingo Lohmar
2016-04-03 11:17 ` Alan Mackenzie
2016-04-03 11:27 ` Andreas Schwab
2016-04-03 11:40 ` Ingo Lohmar
2016-04-03 12:14 ` Alan Mackenzie
2016-04-03 12:30 ` Ingo Lohmar
2016-04-03 14:12 ` Andreas Schwab
2016-04-03 14:57 ` Ingo Lohmar
2016-04-03 15:08 ` Andreas Schwab
2016-04-03 15:12 ` Eli Zaretskii
2016-04-03 15:01 ` Eli Zaretskii
2016-04-03 15:23 ` Ingo Lohmar
2016-04-03 15:40 ` Eli Zaretskii
2016-04-03 16:00 ` Ingo Lohmar
2016-04-03 16:19 ` Eli Zaretskii
2016-04-03 16:24 ` Andreas Schwab
2016-04-03 17:09 ` Eli Zaretskii
2016-04-03 17:35 ` Andreas Schwab
2016-04-03 18:04 ` Eli Zaretskii
2016-04-03 11:44 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FE1882.9030904@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=acm@muc.de \
--cc=emacs-devel@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.