From: Paul Eggert <eggert@cs.ucla.edu>
To: Paul Pogonyshev <pogonyshev@gmail.com>, emacs-devel@gnu.org
Subject: Re: expose XHASH [patch]
Date: Thu, 31 Mar 2016 15:43:33 -0700 [thread overview]
Message-ID: <56FDA815.2090801@cs.ucla.edu> (raw)
In-Reply-To: <CAG7BparKZuRvtACRU2kPS9wyx3Yf4VgZ_LFjNZip5cGr1qkqxw@mail.gmail.com>
On 03/31/2016 12:29 PM, Paul Pogonyshev wrote:
> Attached trivial patch just exposes internally used XHASH(),
> which fully suits this usecase.
Thanks, I like the overall idea but have some quibbles about the details.
The documentation for the new function should be next to the
documentation for sxhash.
Shouldn't we expose hashfn_eq, not XHASH? After all, (make-hash-table
:test 'eq ...) uses hashfn_eq, not XHASH.
Should we also expose hashfn_eql, which is what make-hash-table uses by
default? Or is that a waste of time since hashfn_eql is the default?
Not sure I like the name xhash. Maybe sxhash-eq instead? That would let
us use the name sxhash-eql for hashfn_eql.
next prev parent reply other threads:[~2016-03-31 22:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-31 19:29 expose XHASH [patch] Paul Pogonyshev
2016-03-31 21:52 ` Stefan Monnier
2016-03-31 22:43 ` Paul Eggert [this message]
2016-04-01 9:44 ` Paul Pogonyshev
2016-04-02 11:52 ` Paul Pogonyshev
2016-04-08 16:08 ` Paul Pogonyshev
2016-04-08 18:10 ` Stefan Monnier
2016-04-08 18:37 ` Paul Pogonyshev
2016-04-08 18:44 ` Stefan Monnier
2016-04-08 19:24 ` Paul Pogonyshev
2016-04-08 20:51 ` Stefan Monnier
2016-04-08 22:37 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56FDA815.2090801@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=pogonyshev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.