From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [bug-report] e65c307 breaks font-height Date: Tue, 29 Mar 2016 18:47:30 -0700 Organization: UCLA Computer Science Department Message-ID: <56FB3032.6030104@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1459302472 11563 80.91.229.3 (30 Mar 2016 01:47:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 30 Mar 2016 01:47:52 +0000 (UTC) To: Rostislav Svoboda , "emacs-devel@gnu.org Development" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Mar 30 03:47:42 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1al5ET-0001hN-7g for ged-emacs-devel@m.gmane.org; Wed, 30 Mar 2016 03:47:41 +0200 Original-Received: from localhost ([::1]:51429 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al5ES-00047E-GD for ged-emacs-devel@m.gmane.org; Tue, 29 Mar 2016 21:47:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37412) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al5EO-00046a-SR for emacs-devel@gnu.org; Tue, 29 Mar 2016 21:47:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1al5EL-0006T0-Lf for emacs-devel@gnu.org; Tue, 29 Mar 2016 21:47:36 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:40881) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1al5EL-0006Sv-FA for emacs-devel@gnu.org; Tue, 29 Mar 2016 21:47:33 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3A11F1605F3; Tue, 29 Mar 2016 18:47:32 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id e-yDkw6sIncb; Tue, 29 Mar 2016 18:47:30 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A3ACE161208; Tue, 29 Mar 2016 18:47:30 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id N1k08z36bTBB; Tue, 29 Mar 2016 18:47:30 -0700 (PDT) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 878421605F3; Tue, 29 Mar 2016 18:47:30 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:202433 Archived-At: On 03/29/2016 05:48 AM, Rostislav Svoboda wrote: > It looks like the semicolon in ":user-spec" causes unexpected > font-height increase. > I'm not sure if screenshots help: > http://picpaste.com/emacs-bad-e65c307.png > http://picpaste.com/emacs-good-c8b868b.png > > Is there a problem in the e65c307 or in my emacs configuration? It's pretty clear that the intent here (and elsewhere in Emacs) is that the C identifier 'QCuser_spec' stands for the Emacs symbol ':user-spec', not for the Emacs symbol 'user-spec'. It is possible that the change exposed some other bug in Emacs (perhaps related to font-setting-change-default-font? perhaps you could put a breakpoint on that function and see what it's doing). Or, it's conceivable that your Emacs configuration uses 'user-spec' where it should use ':user-spec'. > thx Bost > > > ~/dev/emacs-25 $ git show > commit e65c3079c65595d95749348366af9811fafff062 > Author: Paul Eggert > Date: Sun Mar 27 15:02:37 2016 -0700 > > * src/font.c (QCuser_spec): Add missing colon to :user-spec. > > diff --git a/src/font.c b/src/font.c > index 5ab3b3e..2519599 100644 > --- a/src/font.c > +++ b/src/font.c > @@ -5317,7 +5317,7 @@ syms_of_font (void) > DEFSYM (Qja, "ja"); > DEFSYM (Qko, "ko"); > > - DEFSYM (QCuser_spec, "user-spec"); > + DEFSYM (QCuser_spec, ":user-spec");