From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas =?UTF-8?Q?R=C3=B6hler?= Newsgroups: gmane.emacs.bugs Subject: bug#13949: 24.4.1; `fill-paragraph' should not always put the buffer as modified Date: Mon, 28 Mar 2016 10:09:58 +0200 Message-ID: <56F8E6D6.9060108@easy-emacs.de> References: <56F12360.5030301@ro.ru> <83y49a4hga.fsf@gnu.org> <56F1837D.4060300@ro.ru> <83io0e4b5r.fsf@gnu.org> <56F19203.5040501@ro.ru> <87a8lkd2bc.fsf@wanadoo.es> <83lh54ynol.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1459152562 16476 80.91.229.3 (28 Mar 2016 08:09:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 28 Mar 2016 08:09:22 +0000 (UTC) To: 13949@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 28 10:09:10 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1akSEY-0002hT-0F for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Mar 2016 10:09:10 +0200 Original-Received: from localhost ([::1]:39646 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akSEX-00081r-5H for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 Mar 2016 04:09:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:52041) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akSET-00081e-6Y for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 04:09:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akSEQ-0003MM-0D for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 04:09:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:43623) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akSEP-0003MI-TD for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 04:09:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1akSEP-0004RD-NU for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 04:09:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 Mar 2016 08:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145915250617012 (code B ref -1); Mon, 28 Mar 2016 08:09:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Mar 2016 08:08:26 +0000 Original-Received: from localhost ([127.0.0.1]:40750 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akSDm-0004QG-Bs for submit@debbugs.gnu.org; Mon, 28 Mar 2016 04:08:26 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:60982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1akSDk-0004Q4-O1 for submit@debbugs.gnu.org; Mon, 28 Mar 2016 04:08:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akSDe-0003Io-IR for submit@debbugs.gnu.org; Mon, 28 Mar 2016 04:08:15 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:48127) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akSDe-0003Ik-FU for submit@debbugs.gnu.org; Mon, 28 Mar 2016 04:08:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:51949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akSDd-0007yP-Ak for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 04:08:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1akSDc-0003IJ-9D for bug-gnu-emacs@gnu.org; Mon, 28 Mar 2016 04:08:13 -0400 Original-Received: from mout.kundenserver.de ([217.72.192.74]:55106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1akSDX-0003HV-L0; Mon, 28 Mar 2016 04:08:07 -0400 Original-Received: from [192.168.178.35] ([95.119.46.51]) by mrelayeu.kundenserver.de (mreue102) with ESMTPSA (Nemesis) id 0Mg7K1-1aPm8e369d-00NTCv; Mon, 28 Mar 2016 10:08:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.5.0 In-Reply-To: <83lh54ynol.fsf@gnu.org> X-Provags-ID: V03:K0:eIz7dB/m5GRvD4n7+Q0zSfE2Et7rd4Kfel1h4MLZHAXes5IiePW oc/xCt/fdsqLx2EHP9o/rkzo0Gx6DnJv6Y1z5ZIY5NvqNznSVhsPOY4HXRebvRIKhuOq9if DcHts0/BNS7CKegXJZwT2uMb1F2xMRPtpqvvtzpOy35Er5YaIUkPqAj7659tU48NK8L2p0c ArfpXSkQNXUKwehBQiL+Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:IYEWVqOUWgo=:Ia/8jhbZfcCwEJK9pR2ihB VqWqoKMxRvx3hPDhQ+LRzng5FWXeFcm/N08QX+q9mGp3vKuzV+W2vC+wQ++zzgdCS1SegCNTQ eVtSd3esPi7kQdHLazwqUZ2ekaxrmJNa7oKJ1zzJHlDvfHSMi45tkqKtyqwrPWVZNR2PAmW2n z/PYCc3SoqeF+t5He6wzYz4eBQuDeMBpIJ9SIW/k6COBMVeyPPaXV1hz6NQsSnbo4bwTB3N1s 22j1yqd8Ev/7KgDYB48guWQmfsPYMZusgHQbsDtQzMD710yjzECpjQhH8FPQySi0ey/cvZ0pE Xj5WIbbARcdkDyq4nsOJ4g9cUotihMaYfY8TA1Vt1MAGwTraWEnQvrBmaUK97Nf2y/UTTR/EH FlTlEGGjHMmFlgnPjxBK7GT/6NWfyvSgE110KXAD7MrvqtoA7hN9pp4Hz8COBOsjR+yq+Zvgp MufhdSvSVZRzlzSSplVCpAQBZZLFBBmR6N40jDIxLLtlHXR7QssJqTy20GThZWDJnqaiJE4q5 aimSZuMmiHmL0jExElyGUS28fmnf3b5G7JGqKw3Dlg0lSdSqPqKERDW7t2GRhKQO4A6jkSTtG C63n9Aum3SkN+DbeQVSPkf1eDiJ7tUfq/GQ83Hs7OfNnuKgV4y4zls2YL9xVGaQ03EqMoNn4T yGe/1XSvWzHwc/KAmGiBtZODDBf75u2Z3a/34UyQ3kV+L/6q1ish3Uf1cEOZHNQrkRXxtB7Ga 0P2DsPC6fiqtQmTV X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115625 Archived-At: On 27.03.2016 16:56, Eli Zaretskii wrote: >> From: Óscar Fuentes >> Date: Sun, 27 Mar 2016 05:31:19 +0200 >> Cc: Jaakov , 13949@debbugs.gnu.org >> >> diff --git a/lisp/textmodes/fill.el b/lisp/textmodes/fill.el >> index 100e2a2..9e1f430 100644 >> --- a/lisp/textmodes/fill.el >> +++ b/lisp/textmodes/fill.el >> @@ -804,6 +804,7 @@ fill-paragraph >> (interactive (progn >> (barf-if-buffer-read-only) >> (list (if current-prefix-arg 'full) t))) >> + (setq h (if (buffer-modified-p) "" (secure-hash 'md5 (current-buffer)))) >> (or >> ;; 1. Fill the region if it is active when called interactively. >> (and region transient-mark-mode mark-active >> @@ -862,7 +863,10 @@ fill-paragraph >> ;; fill-region. >> (fill-region beg end justify) >> (fill-region-as-paragraph beg end justify)))))) >> - fill-pfx))) >> + fill-pfx)) >> + (when (and (not (string= h "")) >> + (string= h (secure-hash 'md5 (current-buffer)))) >> + (set-buffer-modified-p nil))) > Thanks, but I'm not sure computing the hash is enough: the functions > involved in refilling can change text properties, so the test should > also account for that. > > > Maybe restrict the notion of changes here to all values, which an auto-save would store?