From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#23092: 25.0.92; Minibuffer completion fails to resize completion window if reused during same command Date: Thu, 24 Mar 2016 08:43:05 +0100 Message-ID: <56F39A89.5010608@gmx.at> References: <87fuviigpw.fsf@gmail.com> <83k2ku4bb5.fsf@gnu.org> <8737riibq2.fsf@gmail.com> <837fgu49m1.fsf@gnu.org> <56F24F21.4040107@gmx.at> <878u19gn38.fsf@gmail.com> <56F2E647.7040400@gmx.at> <878u18x4um.fsf@mail.linkov.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1458805466 20835 80.91.229.3 (24 Mar 2016 07:44:26 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 24 Mar 2016 07:44:26 +0000 (UTC) Cc: "N. Jackson" , 23092@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 24 08:44:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aizwA-0005uw-Eh for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2016 08:44:10 +0100 Original-Received: from localhost ([::1]:48155 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aizw9-00039Z-C2 for geb-bug-gnu-emacs@m.gmane.org; Thu, 24 Mar 2016 03:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42593) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aizw6-00039P-5i for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 03:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aizw2-0008D3-SV for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 03:44:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:37909) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aizw2-0008Cz-PF for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 03:44:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aizw2-0000id-Fp for bug-gnu-emacs@gnu.org; Thu, 24 Mar 2016 03:44:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 24 Mar 2016 07:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23092-submit@debbugs.gnu.org id=B23092.14588054052695 (code B ref 23092); Thu, 24 Mar 2016 07:44:02 +0000 Original-Received: (at 23092) by debbugs.gnu.org; 24 Mar 2016 07:43:25 +0000 Original-Received: from localhost ([127.0.0.1]:35033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aizvQ-0000hO-Rk for submit@debbugs.gnu.org; Thu, 24 Mar 2016 03:43:25 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:55462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aizvP-0000hC-JL for 23092@debbugs.gnu.org; Thu, 24 Mar 2016 03:43:23 -0400 Original-Received: from [192.168.1.100] ([212.95.7.88]) by mail.gmx.com (mrgmx102) with ESMTPSA (Nemesis) id 0Ld3t6-1a0tgA0QLY-00iBWx; Thu, 24 Mar 2016 08:43:14 +0100 In-Reply-To: <878u18x4um.fsf@mail.linkov.net> X-Provags-ID: V03:K0:od3V6eCpLwfD37TioSpYYB0J7K5h0wubktiHS47yi33JOALUjBy HgOlDku3zD0a4PwSeBw1eHAqPNrOOsBaRKsy2E1WwR1JB/kEq3EfZxRfN2C/Km1lQV3j65i YQD6YVtXT/1OJ7KCD4u2Br1WwcDEdXhxrVjuisyg74vDRH3pv4XbMME6iSQZM3cSIudDMKr aeJMl0x1ndrQfJs39kVrA== X-UI-Out-Filterresults: notjunk:1;V01:K0:e3jkQZxI5yc=:AA7T59WHWIWUEdnwdWqKtf SVC9hZcIoD2Hbvf2qXbIASp0/emZfaKS9/EXaoOBGsVF1UeM/G3ZFzsdC5pzqXAdwaveS9WgJ qvBs9SCmZO9HA7ZhoK+qB0j+ndgsSQbN8vtRxCHIkeCG9xOBNi4xZMRmRNY+13kfvGtAKWwY3 E/jYGb+HxyghHwlGniq2sI7cD3yNIwykxho1fYJN7/BI+mM6nfaB2S57oGFkZ7jf1BqWpsFO2 bxC5ZQDACgMjKHdjjCT/0l38Sl4pEkQ71vALpXUgQTSE+T/4MUF8lIQgeyFvEQAI+wh6EA4by /n1Pvaexwg1HGGZGRiVr2MH8HdCuo0O3cIpGCBivBjaYXwDz+xV9ANkJ1iSb0E1DSAVjWYWWM LtZJ8UPOwtp8z4bR/m6VkTiL9VPTUaSDrcXIKSKYubiKpQImWUZxr4FJaPMSUBfpG5Ecy2w9T p7rR4NR4YrfLH7mw8BhgJh6si1abevocGUvVPlG83KmKA53zTZxReSrA1721560l0RrK1LfW+ RSu7ZAvXvgK7icP7qa/5abSNjNY46eeSLEaAVZ6kQqideFL4fkUIg3Kt3ngxm++c22ApMi+Yu utaCFhU6P4hf1bLnXA3uWSxWN5itGnLpcsxjwbIW9oi+x415ImE6y7SWRkk7MvjXQ+iDXBJPw A0jSDL0j8puQ9JfKUmA09RwgYI2Dg79gZ9m8DS4mhFl+C35QLKJBuKZdX8Vq+r1biqKYQVkC6 XSkaFUi9i+SO6Z0J2InysUI9Nx4AdjIQwOAoXBQmWP3obLD/6WHUnynnD8ioJ3xwBYJ/IKa3 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115433 Archived-At: > However, after I looked at this again now, it looks natural to just > replace =E2=80=98shrink-window-if-larger-than-buffer=E2=80=99 with =E2= =80=98fit-window-to-buffer=E2=80=99. > But I'd leave it to you to decide how good this change is and what > consequences it might entail. It should have two consequences: (1) When there are many completions, the *Completions* window might be larger initially. (2) The *Completions* window will mostly behave as if =E2=80=98temp-buffer-resize= -mode=E2=80=99 were enabled by default. I think the OP's scenario is much more embarrassing so I think we can live with the consequences of your fix. Please install it and I'll fix the manual accordingly. Thanks, martin > diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el > index ecac0ae..6540059 100644 > --- a/lisp/minibuffer.el > +++ b/lisp/minibuffer.el > @@ -1835,7 +1835,7 @@ minibuffer-completion-help > 'display-buffer-below-selected)) > ,(if temp-buffer-resize-mode > '(window-height . resize-temp-buffer-window) > - '(window-height . shrink-window-if-larger-than-buffer)) > + '(window-height . fit-window-to-buffer)) > ,(when temp-buffer-resize-mode > '(preserve-size . (nil . t)))) > nil > >