From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andreas =?UTF-8?Q?R=C3=B6hler?= Newsgroups: gmane.emacs.bugs Subject: bug#13949: 24.4.1; `fill-paragraph' should not always put the buffer as modified Date: Tue, 22 Mar 2016 12:39:17 +0100 Message-ID: <56F12EE5.20301@easy-emacs.de> References: <56F12360.5030301@ro.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1458646763 25568 80.91.229.3 (22 Mar 2016 11:39:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 22 Mar 2016 11:39:23 +0000 (UTC) To: 13949@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Mar 22 12:39:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aiKeV-0002MI-3K for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Mar 2016 12:39:11 +0100 Original-Received: from localhost ([::1]:35466 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiKeU-0001rA-HC for geb-bug-gnu-emacs@m.gmane.org; Tue, 22 Mar 2016 07:39:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42108) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiKeP-0001pY-Jv for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 07:39:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiKeM-0003XF-CI for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 07:39:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60669) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiKeM-0003XB-9l for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 07:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1aiKeL-00086q-Sa for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 07:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andreas =?UTF-8?Q?R=C3=B6hler?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 22 Mar 2016 11:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.145864668331054 (code B ref -1); Tue, 22 Mar 2016 11:39:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 22 Mar 2016 11:38:03 +0000 Original-Received: from localhost ([127.0.0.1]:57794 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aiKdP-00084n-6p for submit@debbugs.gnu.org; Tue, 22 Mar 2016 07:38:03 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50873) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1aiKdN-000841-Hh for submit@debbugs.gnu.org; Tue, 22 Mar 2016 07:38:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiKdF-0003Cf-8p for submit@debbugs.gnu.org; Tue, 22 Mar 2016 07:37:56 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:36789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiKdF-0003CY-5b for submit@debbugs.gnu.org; Tue, 22 Mar 2016 07:37:53 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41802) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiKd9-0000UG-DA for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 07:37:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aiKd5-00039T-3W for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 07:37:47 -0400 Original-Received: from mout.kundenserver.de ([217.72.192.75]:54515) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aiKd4-000399-Q7 for bug-gnu-emacs@gnu.org; Tue, 22 Mar 2016 07:37:43 -0400 Original-Received: from [192.168.178.35] ([77.12.39.103]) by mrelayeu.kundenserver.de (mreue104) with ESMTPSA (Nemesis) id 0Mf1KL-1aOKwX0qV7-00OYcX for ; Tue, 22 Mar 2016 12:37:40 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Icedove/38.5.0 In-Reply-To: <56F12360.5030301@ro.ru> X-Provags-ID: V03:K0:zgnQco7yErl05lQLLxdyNXHUWDVYCaXrYiWeVlvs442I7FPyV3K 2tgeHW6w9LU+ycShYCeis0BE2t8dPRlqqi91gr/DoB4Ix/22n2IvKUAWEaPi5d5X0t58OoH VQi6GvOXzwvMxHQdwcgx7GTKqJuv/7M3If9Bg9swivv0CU2tiBLXqFAedzlFXV0L0wteXCF R38vqNP9bG0Or/YIimTig== X-UI-Out-Filterresults: notjunk:1;V01:K0:BhGXWyzJQ9Q=:DtkC6Blj79SG1fExvutr6g uCqzc93uWTDxcTaxFJHu7KOSizWOjga7wubIGJk6ZrHTNhAM4HIN9SQk8rLnl5OJ4RI8E/IyY zPL1LbcVWBylfeL6cG6/CEPoEeqin45PfbCr7EfHNkHah16NxXqVhNQ/NACGUjUJL9Ae8sHyZ eHV+j7EdKigGjVUUz1Tz2cQXG8fes2byw2E+ilXCrGAwld73UdkydyEZ8iG2ZsXHr3l3CdW7r a6Y5O7Q7pXxt+DfkwrpR3NvbxsjRT+ZBtV0+BGyeTriXOnNBrWaVHzDmxwbtUL6LG9deUPG8P w8BYPsmu35A86caFV6EpQbfH8CWrA8xjPhtulrXq08DdykhTIlR/yTW1YUqk2m/XnM9n7ohFO lg+9+fr78zFs0+GuchwK/hJEcn+iXkmJ86Bfrg7LrfJ7mdki4lA5XMfqCoyeSDixSz3aW4wpX w1k/9vKIfzA6jVAyNq/1XOiommhWYMmehxgQ/9aqomsf3/Y3s5sODBskfiVB3fPqtfmokHIjM MHTBOL6OttloPDHPb6yUOgHyio1J4/ndGcLYX8xonxoTRI1wGMFjWlA5ziXmSuYaG+aT1A749 PihjXx5C2rhGz1WpCbKlrwt1EdZ87WyCcFeK0s4LKWj8NskM5lx1daeb5mG7q/n/vw06BLUfU Hgo/CNOyqIJ3hfjJYO98ZXSXTbr5ebu6Hz8fEnhzyEhXn/y+HEl2yO7G0Lh8r3HmI21ORjkDb VLpHvtvLrF35qIKR X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115308 Archived-At: On 22.03.2016 11:50, Jaakov wrote: > found 13949 24.4.1 > severity 13949 normal > thanks > > Dani said: > > fill-paragraph first removes all the newlines from the paragraph, and > > then inserts only as many as needed to get a filled paragraph. So the > > buffer gets changed at least twice in the process. > > This is _how_ it is done, not _what_ is done. Then "what" is described > in the documentation > > https://www.gnu.org/software/emacs/manual/html_node/elisp/Buffer-Modification.html > : > > "Emacs keeps a flag called the modified flag for each buffer, to > record whether you have changed the text of the buffer. This flag is > set to t whenever you alter the contents of the buffer, and cleared to > nil when you save it." > > The description of fill-paragraph at > > http://www.gnu.org/software/emacs/manual/html_node/emacs/Fill-Commands.html > > > mentions no exception to the above and "Emacs always behaved like > that" is just saying that the issue is old. > > Since fill-paragraph does not heed the above piece of > "modified"-flag--documentation, it represents a non-compliance with > the (informal) specification, i.e., a typical bug. > > Therefore, I changed the severity from wishlist to normal. > > There are two ways to deal with it: to repair fill-paragraph or to > repair the documentation. > > (A non-related personal aside: since recently, I had to rely both on > the star in the left lower corner /which means modified/ and paragraph > filling quite a lot. So the issue really, really bothers me. Of > course, nobody is forced to repair it if it is just extremely hard to > do. We are all busy. But I would be extremely happy to see the > fill-paragraph repaired, at least for text-mode and latex-mode > with/without installed auctex, if it makes any difference. > > Btw., I tend to think that hash computing like sha1 could potentially > lead to rare, hard-to-reproduce hash clashes, where the text has > changed, but the sha1 says that the text is the same. If so, > implementing hash-checking would be worse that the current situation.) > > > IMHO fill-paragraph deserves a clean-up, a complete re-write. Initial relying at return-values of or-clause looks error-prone.