bug#23003: 25.1.50; --with-x-toolkit options cause the build to fail.

[Paul Eggert <eggert@cs.ucla.edu>]

Keith David Bershatsky wrote:

> 1.  The patch you proposed resolves the following issue with gtk3 in the master branch, which cannot be resolved absent applying the patch.

Yes, I reproduced a similar problem on Fedora, and tested that the patch works.

The patch has already been applied to the emacs-25 branch, so it shouldn't be 
applied there again. It should be applied to the master branch in the next merge 
from emacs-25; at that point you won't need to apply it yourself any more.

> 2.  The patch has nothing to do with the errors when building athena and motif.  Instead, running `make clean` in between builds resolves those issues:
>
>      * * *
>
>      image.c:6116: warning: comparison is always false due to limited range of data type
>      image.c:6116: warning: comparison is always false due to limited range of data type
>      image.c:6116: warning: comparison is always false due to limited range of data type

You can safely ignore these warnings.

>        CCLD     temacs
>      Undefined symbols:
>        "_xaw_create_dialog", referenced from:
>            _lw_make_widget in liblw.a(lwlib.o)

These symbols ought to be defined in lwlib/lwlib-Xlw.o. On my platform:

> $ nm -o lwlib/liblw.a | grep xlw_update_one_widget
> lwlib/liblw.a:lwlib.o:                 U xlw_update_one_widget
> lwlib/liblw.a:lwlib-Xlw.o:0000000000000310 T xlw_update_one_widget

You might investigate why this isn't working for you. One possibility is that 
RANLIB isn't defined correctly on your platform; see lwlib/Makefile.