From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nikolay Kudryavtsev Newsgroups: gmane.emacs.bugs Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read Date: Mon, 21 Mar 2016 22:35:46 +0300 Message-ID: <56F04D12.8020105@gmail.com> References: <56EFD97C.3080805@gmail.com> <83wpov6c35.fsf@gnu.org> <87d1qng4aj.fsf@wanadoo.es> <87egb3r9wc.fsf@linux-m68k.org> <83k2kv66bj.fsf@gnu.org> <56F04154.9010405@gmail.com> <83bn6763pd.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1458589047 10482 80.91.229.3 (21 Mar 2016 19:37:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 19:37:27 +0000 (UTC) Cc: =?UTF-8?Q?=C3=93scar?= Fuentes , 23075@debbugs.gnu.org, Andreas Schwab To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 20:37:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai5dY-0004Fx-7W for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 20:37:12 +0100 Original-Received: from localhost ([::1]:59965 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5dX-0000qC-O7 for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 15:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60937) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5dR-0000q3-Lp for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:37:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai5dO-0001hY-E5 for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:37:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60201) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai5dO-0001hU-AD for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:37:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ai5dO-00078k-5e for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 15:37:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nikolay Kudryavtsev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 19:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23075 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23075-submit@debbugs.gnu.org id=B23075.145858897227387 (code B ref 23075); Mon, 21 Mar 2016 19:37:02 +0000 Original-Received: (at 23075) by debbugs.gnu.org; 21 Mar 2016 19:36:12 +0000 Original-Received: from localhost ([127.0.0.1]:57328 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai5cZ-00077f-Q3 for submit@debbugs.gnu.org; Mon, 21 Mar 2016 15:36:11 -0400 Original-Received: from mail-lb0-f171.google.com ([209.85.217.171]:36577) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai5cX-00077O-AI for 23075@debbugs.gnu.org; Mon, 21 Mar 2016 15:36:09 -0400 Original-Received: by mail-lb0-f171.google.com with SMTP id qe11so79071597lbc.3 for <23075@debbugs.gnu.org>; Mon, 21 Mar 2016 12:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:to:references:cc:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=nDqJo3FSF2NdxeaBUqMAa5Iq64R7sRVo4QqrzG3ntbs=; b=AGzzJE8YnCp0SEjxGeIVk6xzt7lJOf+3vgrpjAdozIiA/i4vm4XNQ1qeaUO1KmdL5n YquU9dK5eBGOhfDKZXtMVMZ6FABIyPx+IkCqCK69+Pm0CF4b4JU0vuUFa4dAXR+t66y0 FBQiyFH9Kxxl0Fua/HKxeEZM+9jicOgiKoxCq9u+NwnBa3aaKcv9rzpH16W7vi2+W9HN r25sxJm/B393+UoYVt4qHoU0osve7h9sX5PvLRBLbM7y6j0E1C5qhL9fys6ei0frCKJy pCRcsX6+GZUYtzFkmrrIHUj5DsRsOMDHuJDSH5BOiAdZSaXh5RjAG86R63OkmE3C5y6G m22A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:to:references:cc:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=nDqJo3FSF2NdxeaBUqMAa5Iq64R7sRVo4QqrzG3ntbs=; b=b0OsgsnsyKiOBDiKFAuvA7z0zyWbRCWw/bQ1QGI73EwIGksPM+KmnCuxY68BVblLcW gmd+gAwdGSLXDaxIrABMC0vJPtpXq8qF2AWB7mofsbqUPfN286bsOt0y9FuHcISpHahX pJQb5Nrmy/vAX2c99fg/Terw3wNuVvjzL4mzR41DBKElYfi3ZWrBmnVTDi54ZuEOqENu 3PSfQvFwNZ3nChHz0Tb+ynjaG/mC+3jmrBGjOOyIaTNDVbBLCEmYqB7961CCKW07hi5L VavVYcNdE3bCKPc25Gz8Bp9jXLA2utlZUn//rxpzhPHpqx9L5BthChd/NO46RoHa7U+w ZkIw== X-Gm-Message-State: AD7BkJIUkMqCTFfsEJkCFZu6TE/uPbfPtayVtR9NIgq87CsOFu1gh2Jq29YVM22J+ju1Pg== X-Received: by 10.112.170.68 with SMTP id ak4mr9382451lbc.94.1458588963376; Mon, 21 Mar 2016 12:36:03 -0700 (PDT) Original-Received: from [192.168.199.2] (broadband-95-84-209-126.nationalcablenetworks.ru. [95.84.209.126]) by smtp.gmail.com with ESMTPSA id s193sm4877999lfe.29.2016.03.21.12.36.02 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Mar 2016 12:36:02 -0700 (PDT) X-Google-Original-From: Nikolay Kudryavtsev User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 In-Reply-To: <83bn6763pd.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115266 Archived-At: > Then the encoding of the file being visited is no longer as relevant as in the use case you describe. That's true, and whoever wrote this part of vc was aware of the issue, as you can see from that comment. The simple fix at least allow getting diff for the file in a different encoding, even if you have to diff that file alone. I can confirm that Oscar's issue with HELLO is the same thing. What he described as garbage was probably the result of vc-diff encoded in utf-8 since that's the default value of vc-git-commits-coding-system. -- Best Regards, Nikolay Kudryavtsev