From: Nikolay Kudryavtsev <nikolay.kudryavtsev@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "Óscar Fuentes" <ofv@wanadoo.es>,
23075@debbugs.gnu.org, "Andreas Schwab" <schwab@linux-m68k.org>
Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read
Date: Mon, 21 Mar 2016 22:35:46 +0300 [thread overview]
Message-ID: <56F04D12.8020105@gmail.com> (raw)
In-Reply-To: <83bn6763pd.fsf@gnu.org>
> Then the encoding of the file being visited is no longer as relevant as in the use case you describe.
That's true, and whoever wrote this part of vc was aware of the issue,
as you can see from that comment. The simple fix at least allow getting
diff for the file in a different encoding, even if you have to diff that
file alone.
I can confirm that Oscar's issue with HELLO is the same thing. What he
described as garbage was probably the result of vc-diff encoded in utf-8
since that's the default value of vc-git-commits-coding-system.
--
Best Regards,
Nikolay Kudryavtsev
next prev parent reply other threads:[~2016-03-21 19:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 11:22 bug#23075: 24.5; vc-git-command should use coding-system-for-read Nikolay Kudryavtsev
2016-03-21 16:16 ` Eli Zaretskii
2016-03-21 16:54 ` Óscar Fuentes
2016-03-21 17:21 ` Eli Zaretskii
2016-03-21 17:57 ` Andreas Schwab
2016-03-21 18:05 ` Óscar Fuentes
2016-03-21 18:22 ` Eli Zaretskii
2016-03-21 19:38 ` Óscar Fuentes
2016-04-02 10:02 ` Eli Zaretskii
2016-03-21 18:20 ` Eli Zaretskii
2016-03-21 18:45 ` Nikolay Kudryavtsev
2016-03-21 19:17 ` Eli Zaretskii
2016-03-21 19:35 ` Nikolay Kudryavtsev [this message]
2016-04-02 9:58 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56F04D12.8020105@gmail.com \
--to=nikolay.kudryavtsev@gmail.com \
--cc=23075@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=ofv@wanadoo.es \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.