From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Nikolay Kudryavtsev Newsgroups: gmane.emacs.bugs Subject: bug#23075: 24.5; vc-git-command should use coding-system-for-read Date: Mon, 21 Mar 2016 21:45:40 +0300 Message-ID: <56F04154.9010405@gmail.com> References: <56EFD97C.3080805@gmail.com> <83wpov6c35.fsf@gnu.org> <87d1qng4aj.fsf@wanadoo.es> <87egb3r9wc.fsf@linux-m68k.org> <83k2kv66bj.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1458586039 25706 80.91.229.3 (21 Mar 2016 18:47:19 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Mar 2016 18:47:19 +0000 (UTC) Cc: 23075@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 21 19:47:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ai4r7-0007QX-Ue for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 19:47:10 +0100 Original-Received: from localhost ([::1]:59775 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai4r7-0004r3-Gf for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 Mar 2016 14:47:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49620) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai4r4-0004qw-6n for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 14:47:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ai4r0-0006VZ-Up for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 14:47:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60152) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ai4r0-0006VU-Oi for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 14:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ai4r0-0004Ee-Gg for bug-gnu-emacs@gnu.org; Mon, 21 Mar 2016 14:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Nikolay Kudryavtsev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 21 Mar 2016 18:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23075 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23075-submit@debbugs.gnu.org id=B23075.145858596616214 (code B ref 23075); Mon, 21 Mar 2016 18:47:02 +0000 Original-Received: (at 23075) by debbugs.gnu.org; 21 Mar 2016 18:46:06 +0000 Original-Received: from localhost ([127.0.0.1]:57279 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai4q6-0004DS-3O for submit@debbugs.gnu.org; Mon, 21 Mar 2016 14:46:06 -0400 Original-Received: from mail-lb0-f182.google.com ([209.85.217.182]:36392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ai4q3-0004Ck-Sv for 23075@debbugs.gnu.org; Mon, 21 Mar 2016 14:46:04 -0400 Original-Received: by mail-lb0-f182.google.com with SMTP id qe11so77674176lbc.3 for <23075@debbugs.gnu.org>; Mon, 21 Mar 2016 11:46:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:subject:references:cc:to:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=k2esoL274PbDF6031TQGYjlvfmMEmiitVzwgc2yuCbA=; b=hOfRpKJVy2qYLqmBDEyRNEy0l4VwWLW+SIZtBpDPbC4Xf9GUk9VXwqt826zYUZpRfp Vpd1u5y9zeWvhc6/Gm0OlVjbsJ2JRIoF0jpMHfzEl2RkRqQODjiXaBIe6NIiUxbnGt8G AeW9DDmiXQKo/zIC7XFMBsAyxFcaVrFST9iMR6moVmZZSLbsL62FZzGJ4H18BuGNoP67 NQmtxGKewVJHXG2vmF38ltvUAb/thgeSKfmTkq/xM0j+OBGqmrqiZ2Z8JIIlAxWah//E N4tYKqpKjVoZ22i7EMmnmqTzl9+CjrLwt2I9IablXaYHxgCmEiipV5lPTCbxPszbv+cw U6XA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:subject:references:cc:to:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=k2esoL274PbDF6031TQGYjlvfmMEmiitVzwgc2yuCbA=; b=RzBQK4TUXQJYG30mmzX2v3zdpGNFXDPBiBlOEvEAx2WdwE/tTPp0DbMD2FSIcDFrsE YOp5binuFK41zNjJkiVQboCiHiCIlexQ2VcT6IkQtLCKKsbBn21O57EGX1pVVq2aZ0Pe 3sfL+wp8CMaxg7vao8TKSHKjnFThqVmVJCEhLryeKxIad0+JdW1RQskqMvPp1eBt5nWI wIefDAQrENxn+B8UrjnXfw12+fQ/vLjPNhBEAgoHiRLfulHQ1iZL6iQ+A4167gNcA/t3 rf91NJGdnXNNLP+GrStDkJtZ+7hGYIm93KsS8WUD0ZgxXE5BaIVOonCKYjDQgI4drhC6 D34w== X-Gm-Message-State: AD7BkJLYH6jI2FZsHqLwonRqYQXFTz0KiaPLcip4JJwvUAsx4ZnBBPwTPLZ1+x4ZNvJMuQ== X-Received: by 10.112.73.69 with SMTP id j5mr11303205lbv.17.1458585958065; Mon, 21 Mar 2016 11:45:58 -0700 (PDT) Original-Received: from [192.168.199.2] (broadband-95-84-209-126.nationalcablenetworks.ru. [95.84.209.126]) by smtp.gmail.com with ESMTPSA id e82sm4743013lfi.38.2016.03.21.11.45.56 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 Mar 2016 11:45:57 -0700 (PDT) X-Google-Original-From: Nikolay Kudryavtsev User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 In-Reply-To: <83k2kv66bj.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115258 Archived-At: Hello. Ok, here are more detailed steps on how to repeat this this bug. 1. Clone https://github.com/sg2002/vc-git-bugs 2. Open 1251.txt in windows1251 encoding. Do some changes in it. 3. vc-diff. This would give you diff with broken encoding. 4. Evaluate vc-git-command from fix.el in the repo. 5. vc-diff again, it would give you the correct encoding as long as the file itself opened correctly. Yes, there is some code that specifies encoding in vc already. See the first large comment in vc-diff-internal. This issue is not platform specific, unlike 23076. -- Best Regards, Nikolay Kudryavtsev