From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#23003: 25.1.50; --with-x-toolkit options cause the build to fail. Date: Thu, 17 Mar 2016 23:57:34 -0700 Organization: UCLA Computer Science Department Message-ID: <56EBA6DE.3030208@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------010603030303050706040709" X-Trace: ger.gmane.org 1458284303 1025 80.91.229.3 (18 Mar 2016 06:58:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 18 Mar 2016 06:58:23 +0000 (UTC) Cc: 23003@debbugs.gnu.org To: Keith David Bershatsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Mar 18 07:58:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1agoMN-00055c-2p for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Mar 2016 07:58:11 +0100 Original-Received: from localhost ([::1]:41952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agoMM-0004OG-BH for geb-bug-gnu-emacs@m.gmane.org; Fri, 18 Mar 2016 02:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45705) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agoMH-0004Le-V2 for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 02:58:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1agoME-0002Qq-Mo for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 02:58:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54568) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1agoME-0002Qm-I2 for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 02:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1agoME-0006eV-CK for bug-gnu-emacs@gnu.org; Fri, 18 Mar 2016 02:58:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Paul Eggert Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Mar 2016 06:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23003 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 23003-submit@debbugs.gnu.org id=B23003.145828426925551 (code B ref 23003); Fri, 18 Mar 2016 06:58:02 +0000 Original-Received: (at 23003) by debbugs.gnu.org; 18 Mar 2016 06:57:49 +0000 Original-Received: from localhost ([127.0.0.1]:51695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agoM0-0006e2-Qy for submit@debbugs.gnu.org; Fri, 18 Mar 2016 02:57:49 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:48649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1agoLz-0006dq-5o for 23003@debbugs.gnu.org; Fri, 18 Mar 2016 02:57:47 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 3250B160E42; Thu, 17 Mar 2016 23:57:41 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id AK8sLicpWvBL; Thu, 17 Mar 2016 23:57:39 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D0647160F86; Thu, 17 Mar 2016 23:57:39 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 1eJ1N3ZN58DJ; Thu, 17 Mar 2016 23:57:39 -0700 (PDT) Original-Received: from [192.168.1.9] (pool-100-32-155-148.lsanca.fios.verizon.net [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 76AD4160E42; Thu, 17 Mar 2016 23:57:39 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:115022 Archived-At: This is a multi-part message in MIME format. --------------010603030303050706040709 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit > emacsgtkfixed.c:36: error: redefinition of typedef 'EmacsFixedPrivate' > ... > emacsgtkfixed.c:37: error: redefinition of typedef 'EmacsFixedClass' Thanks for reporting the problem. It looks like you have a picky C99 compiler that rejects duplicate typedefs. I installed into the emacs-25 branch the attached patch to fix this porting glitch; please give it a try. The other diagnostics look like you ran './configure FOO-OPTIONS; make; ./configure BAR-OPTIONS; make', which does not work in general. When switching 'configure' options, in general one must start with a fresh tree. One way to do this is to leave the source tree alone and build in a separate directory, e.g.: tar xf emacs-25.1.50.tar.gz mkdir build-foo cd build-foo ../emacs-25.1.50/configure FOO-OPTIONS make cd .. mkdir build-bar cd build-bar ../emacs-25.1.50/configure BAR-OPTIONS make cd .. So please try something like the above, after installing the attached patch. --------------010603030303050706040709 Content-Type: text/x-diff; name="0001-Port-to-GTK-with-strict-C99-compiler.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-Port-to-GTK-with-strict-C99-compiler.patch" >From 09154cfbe27159d5a9f0acd3e3ae89c6969f694d Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Thu, 17 Mar 2016 23:45:02 -0700 Subject: [PATCH] Port to GTK with strict C99 compiler * src/emacsgtkfixed.c: Use workaround for GNOME bug 683906 only in glib 2.35.6 and earlier, since the bug is fixed in 2.35.7. * src/emacsgtkfixed.c (EmacsFixedPrivate): * src/emacsgtkfixed.h (EmacsFixedClass): Remove duplicate typedef, which strict C99 does not allow (Bug#23003). --- src/emacsgtkfixed.c | 3 +-- src/emacsgtkfixed.h | 1 - 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/emacsgtkfixed.c b/src/emacsgtkfixed.c index cebd7b6..ca0bbfb 100644 --- a/src/emacsgtkfixed.c +++ b/src/emacsgtkfixed.c @@ -27,13 +27,12 @@ along with GNU Emacs. If not, see . */ #include "emacsgtkfixed.h" /* Silence a bogus diagnostic; see GNOME bug 683906. */ -#if 4 < __GNUC__ + (7 <= __GNUC_MINOR__) +#if 4 < __GNUC__ + (7 <= __GNUC_MINOR__) && ! GLIB_CHECK_VERSION (2, 35, 7) # pragma GCC diagnostic push # pragma GCC diagnostic ignored "-Wunused-local-typedefs" #endif typedef struct _EmacsFixed EmacsFixed; -typedef struct _EmacsFixedPrivate EmacsFixedPrivate; typedef struct _EmacsFixedClass EmacsFixedClass; struct _EmacsFixedPrivate diff --git a/src/emacsgtkfixed.h b/src/emacsgtkfixed.h index 3d6a76a..0d09525 100644 --- a/src/emacsgtkfixed.h +++ b/src/emacsgtkfixed.h @@ -30,7 +30,6 @@ G_BEGIN_DECLS struct frame; typedef struct _EmacsFixedPrivate EmacsFixedPrivate; -typedef struct _EmacsFixedClass EmacsFixedClass; struct _EmacsFixed { -- 2.5.0 --------------010603030303050706040709--