From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#22583: 25.1.50; find-library don't call find-function-after-hook Date: Mon, 22 Feb 2016 01:27:03 +0200 Message-ID: <56CA47C7.1090605@yandex.ru> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1456097307 16926 80.91.229.3 (21 Feb 2016 23:28:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 21 Feb 2016 23:28:27 +0000 (UTC) To: Tino Calancha , 22583@debbugs.gnu.org, John Wiegley Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Feb 22 00:28:15 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aXdQF-0000zf-HJ for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Feb 2016 00:28:15 +0100 Original-Received: from localhost ([::1]:44958 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXdQB-0004Hd-Kn for geb-bug-gnu-emacs@m.gmane.org; Sun, 21 Feb 2016 18:28:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXdQ7-0004Gx-RK for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2016 18:28:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aXdQ2-00009r-Rd for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2016 18:28:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39565) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aXdQ2-00009m-Ms for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2016 18:28:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aXdQ2-0000h9-Gi for bug-gnu-emacs@gnu.org; Sun, 21 Feb 2016 18:28:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 21 Feb 2016 23:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22583 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22583-submit@debbugs.gnu.org id=B22583.14560972332615 (code B ref 22583); Sun, 21 Feb 2016 23:28:02 +0000 Original-Received: (at 22583) by debbugs.gnu.org; 21 Feb 2016 23:27:13 +0000 Original-Received: from localhost ([127.0.0.1]:36692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXdPF-0000g7-0L for submit@debbugs.gnu.org; Sun, 21 Feb 2016 18:27:13 -0500 Original-Received: from mail-wm0-f52.google.com ([74.125.82.52]:38292) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aXdPD-0000fu-LR for 22583@debbugs.gnu.org; Sun, 21 Feb 2016 18:27:11 -0500 Original-Received: by mail-wm0-f52.google.com with SMTP id a4so140135521wme.1 for <22583@debbugs.gnu.org>; Sun, 21 Feb 2016 15:27:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=f+WBalybz75d1avQhTmcCpeyJEjfr1bMC8dCTxan4do=; b=g7R+Bd70U0Mj0CbX2ka3pvlNSwlDFotyYW1ghdkSqlGHdKW1gfLhZGIRYu9CnJdJ63 rih7T128Lq5Eef3oivjjh0aGQmxYcAWWLVVrDq0UWhrefBjJR5v5toub5RTgvgH04Ln8 xKJGWIX1klm18jF5ZDnf/SyX1wgMmEpCsksiDVvm6jffhbi8sLCgR6g/Jr5kVafow1cq gUeyDGWxxKyKdefP/XxUUq/SlrnG2YoNANNMIJiTuPtsmwbZsCVq6Pvh1aJ2PT4jAgFS GvnDcEdi+1xa1LXsIuLJWTYADzNZfXM9SSCESMAIpyj+BHP2o/+Bc5+YylalYHUUXbpP IblA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=f+WBalybz75d1avQhTmcCpeyJEjfr1bMC8dCTxan4do=; b=TKfwRPjHxnCdiapCPzHqnv2lOXAOK3OYzzYsNZQYAjLytzyMMEICU4KKPQt6GqjU7M ddM/x0nZHD+sOVTIndopk8fa3rrJ9yU/BE9doljQMjgZBM7BZaNetEJ6BFAjnaXymRw4 7lAKPTuocUTkQucJr/2JGVtbgxnNbCPDBPtkRi2p5RYnmVWH0NiE/FAXlOzV/0ES4HoZ W2eSSNChKcBcrmgC6l17YJL/MtNkGJdcmSb2rkhlNNqkMEIx3nWFF0EVK4tclQ5A82u5 QRYqYs5pjFmbZD6PTk2Aq3WyW97vVxB+n9FvAa4d30D369+3oqjFWKKcj2NHl6nW3vpI JY1Q== X-Gm-Message-State: AG10YOSec2S1gxHuxSzGNU2YXkVCYmlBSvytjO2cIBmy15++BTi9SLKlseJ4nHs6kmi0cw== X-Received: by 10.194.120.99 with SMTP id lb3mr29583111wjb.59.1456097226227; Sun, 21 Feb 2016 15:27:06 -0800 (PST) Original-Received: from [192.168.1.2] ([185.105.175.24]) by smtp.googlemail.com with ESMTPSA id x66sm18368523wmb.20.2016.02.21.15.27.04 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 21 Feb 2016 15:27:05 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113433 Archived-At: On 02/18/2016 02:52 AM, Tino Calancha wrote: > > IMO, for consistency, find-function-after-hook should be > also run by find-library. > For instance, as mentioned above, i set this hook to always > open source code on read-only buffers. > If find-library don't run the hook, it may open a file in > writable mode. Sounds good to me. Tino, could you resend these as one patch, using 'git format-patch' as described in CONTRIBUTE, with an appropriate commit message (which means using ChangeLog-style description, as also described in CONTRIBUTE). John, would you say it's okay for emacs-25?