From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>,
Fabrice Popineau <fabrice.popineau@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Recent commits break compilation for MinGW64
Date: Thu, 11 Feb 2016 13:33:39 -0800 [thread overview]
Message-ID: <56BCFE33.7080302@cs.ucla.edu> (raw)
In-Reply-To: <831t8j9e0m.fsf@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 840 bytes --]
On 02/11/2016 12:40 PM, Eli Zaretskii wrote:
>> From: Fabrice Popineau <fabrice.popineau@gmail.com>
>> Date: Thu, 11 Feb 2016 07:20:32 +0000 (UTC)
>>
>> The use of va_start() and consorts
>> requires
>> #include <stdarg.h>
Sorry about that. Fixed with the attached. On GNU/Linux, lib/stdio.h
includes <stdarg.h> which is why the compile worked for me.
> I think such commits shouldn't happen at all on emacs-25, but on
> master. IMO, the time for cleanups on the release branch has come and
> gone.
The overall commit was needed to port to GCC 4.8 and later with
-fsanitize=address. In hindsight perhaps I should have stuck with the
old non-stdarg API for the newly added diagnostics (on the other hand
perhaps not -- the old API was hard to follow and the confusion caused a
bug in my first version, which is why I changed it).
[-- Attachment #2: 0001-lib-src-make-docfile.c-Include-stdarg.h.patch --]
[-- Type: application/x-patch, Size: 636 bytes --]
prev parent reply other threads:[~2016-02-11 21:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-11 7:20 Recent commits break compilation for MinGW64 Fabrice Popineau
2016-02-11 20:40 ` Eli Zaretskii
2016-02-11 21:33 ` Paul Eggert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BCFE33.7080302@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=fabrice.popineau@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.