all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: "Óscar Fuentes" <ofv@wanadoo.es>, 22577@debbugs.gnu.org
Subject: bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files
Date: Mon, 8 Feb 2016 06:46:37 +0200	[thread overview]
Message-ID: <56B81DAD.8010303@yandex.ru> (raw)
In-Reply-To: <878u2xyztc.fsf@telefonica.net>

On 02/07/2016 05:17 AM, Óscar Fuentes wrote:

> I propose the following patch to fix this problem. Shell gurus, please
> review.

(Not a guru here.)

> diff --git a/lisp/progmodes/grep.el b/lisp/progmodes/grep.el
> index 7e6f157..3f77a2a 100644
> --- a/lisp/progmodes/grep.el
> +++ b/lisp/progmodes/grep.el
> @@ -189,7 +189,7 @@ grep-find-template
>     :group 'grep)
>
>   (defcustom grep-files-aliases
> -  '(("all" .   "* .*")
> +  '(("all" .   "* .[^\\.]*")

I think you don't even need the escape (and it would create a false 
negative for file names starting with '.\'; but nobody should have those 
anyway). Otherwise, it looks good.





  reply	other threads:[~2016-02-08  4:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-07  3:17 bug#22577: 25.0.50; vc-git-grep fails when searching for `all' files Óscar Fuentes
2016-02-08  4:46 ` Dmitry Gutov [this message]
2016-02-08  5:59   ` Óscar Fuentes
2016-02-08 11:16     ` Andreas Schwab
2016-02-08 16:10       ` Óscar Fuentes
2016-02-08 16:22       ` Óscar Fuentes
2016-02-08 16:28         ` Andreas Schwab
2016-02-08 18:14         ` Dmitry Gutov
2016-02-08 18:41         ` Andreas Schwab
2016-02-14 15:24         ` Óscar Fuentes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56B81DAD.8010303@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=22577@debbugs.gnu.org \
    --cc=ofv@wanadoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.