From: Paul Eggert <eggert@cs.ucla.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>, emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 605f901: Prefer memcpy and memset to doing it by hand
Date: Fri, 5 Feb 2016 14:40:47 -0800 [thread overview]
Message-ID: <56B524EF.7000507@cs.ucla.edu> (raw)
In-Reply-To: <jwv1t8rtho0.fsf-monnier+emacsdiffs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 525 bytes --]
On 02/05/2016 05:25 AM, Stefan Monnier wrote:
> FWIW, I much prefer keeping just the loop, over using this "if+memset"
> which seems like an obvious case or too-early-optimization.
Fair enough, I didn't measure it and you're probably right that it's not
worth the complexity. I changed it to use just the loop, with the
attached patch.
This patch's commit message documents what I had *originally* put in
there in my private copy, something that I fondly hope would have made
the hair on the back of your neck stand up.
[-- Attachment #2: 0001-Omit-XLI-init-0-optimization-in-make-vector.patch --]
[-- Type: application/x-patch, Size: 1293 bytes --]
next prev parent reply other threads:[~2016-02-05 22:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20160205003917.14369.86929@vcs.savannah.gnu.org>
[not found] ` <E1aRUQf-0003kP-6V@vcs.savannah.gnu.org>
2016-02-05 13:25 ` [Emacs-diffs] master 605f901: Prefer memcpy and memset to doing it by hand Stefan Monnier
2016-02-05 22:40 ` Paul Eggert [this message]
2016-02-07 17:53 ` John Wiegley
2016-02-07 21:24 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56B524EF.7000507@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.