From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-25 504696d: Etags: yet another improvement in Ruby tags Date: Fri, 5 Feb 2016 13:11:50 +0300 Message-ID: <56B47566.5090806@yandex.ru> References: <20160203162536.2954.45438@vcs.savannah.gnu.org> <56B29165.3040404@yandex.ru> <8337t9xhjc.fsf@gnu.org> <56B31B99.6010400@yandex.ru> <83io24wfjl.fsf@gnu.org> <56B4329D.7010101@yandex.ru> <83mvrfv7s3.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1454667158 16463 80.91.229.3 (5 Feb 2016 10:12:38 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 5 Feb 2016 10:12:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Feb 05 11:12:24 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aRdNI-00011n-5m for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2016 11:12:24 +0100 Original-Received: from localhost ([::1]:47267 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRdNH-0003bb-Ff for ged-emacs-devel@m.gmane.org; Fri, 05 Feb 2016 05:12:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35634) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRdMr-0003Xs-2z for emacs-devel@gnu.org; Fri, 05 Feb 2016 05:11:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aRdMn-0001TQ-0d for emacs-devel@gnu.org; Fri, 05 Feb 2016 05:11:56 -0500 Original-Received: from mail-lf0-x22c.google.com ([2a00:1450:4010:c07::22c]:35883) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aRdMm-0001TE-Nn; Fri, 05 Feb 2016 05:11:52 -0500 Original-Received: by mail-lf0-x22c.google.com with SMTP id 78so53936239lfy.3; Fri, 05 Feb 2016 02:11:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=OITRPV/WwtoXtoelvF8hlj6tPu9jaDV5Yv3HPBFdWyU=; b=YKryvqYQior7IAdYNQlAbx0mOE8XSxRsuJJD/ujlThc3BuqS9jv8Hud2ZL7c+AtyiL 52g7JOO7V7KTg/PELAdHk1HWu+hSiIlQi7e+8sHULjxBU8Je4mrcnrWdjcu92Rx+6wUT i1n40uQvMGfTs0rkq0GvN24dYyVQsXcwiUPx3q1wrfKzRAZ+Nm0/5iD3olsulkJHUMog rYlngZQnCTkGD7YBmz03oKUGP3VBKz846dHfSv3zV80d92ORbozS/fCSLSxMYRQTzqZp AlV6PvUxXllDai085Bmvb61Jfi/CU3D36n9QLZzH159nEKx7clOtUAhqdNq6OmMsgRDY I9cw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=OITRPV/WwtoXtoelvF8hlj6tPu9jaDV5Yv3HPBFdWyU=; b=HgHWS2G3xBd63tqxfTLyrd5bYnAKGT2KMVHAIvQS7T7z+PEx2oTibFsF6b/aHjemgV /1hyyMOsAcr160qSiNukgFniZd4FlEm8kH9ckqBqibf0fYRScjiGI7rsIJ4aIfYeiP1A f3aOcDdrpcag5bf93hdHlkYrnsRpYpVa5VYV2VNU1B/pkSUVhZauetvbB8/wQ7HqNLoc NCeGtc0mHKYG74mTW7vkw8oLHnfelBvCCxGDDrtq7UEcRYV6LIix97iqb2ieuL3GO37Z HxFnfUcGJ6ArSnHTdya7P7z/fhmMUMymk3Rs0QSlaS5JU8+Mgg3NcG+xn7WCaszIuemT XUSw== X-Gm-Message-State: AG10YOQHQKXGl5Jof/XeOO2zVTWHuO9pbJOpVNnytwsQLTgX5BsyCfavs/sYeQZwSrC7WQ== X-Received: by 10.25.21.90 with SMTP id l87mr5548432lfi.64.1454667111620; Fri, 05 Feb 2016 02:11:51 -0800 (PST) Original-Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id mj4sm2144850lbc.19.2016.02.05.02.11.50 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 05 Feb 2016 02:11:50 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 In-Reply-To: <83mvrfv7s3.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::22c X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199370 Archived-At: On 02/05/2016 12:14 PM, Eli Zaretskii wrote: > No. What comes after the comma must begin with attr_SOMETHING or > alias_method. The issue being tested here is that we are not in a > state where matches for these are being tried. alias_method :qux, :tee, attr_accessor(:bogus) or alias_method :qux, :tee, alias_method(:bogus, :bogus2) are the main options, I suppose. But they might also look misleading, and indicate that we don't support the paren-using syntax intentionally. (It's another omission, but AFAICS nobody uses attr_XXX without parens in the context we're interested in.) > But if you ever figure out how to do that with a less abnormal syntax, > feel free to update the test files. The problem with me updating the tests is I can't revert the corresponding fix and make sure that the test fails without it. > It could also be a good idea to add a Rakefile or a Thorfile to the > ruby-src directory (when I tested the change, I just renamed one of > the other files). It could be that those present special challenges, > and in any case we should test the file-name rules. I believe the file-name rules should be tested in a language-agnostic way, or just with one language. There's not much point in having all possible file names in test/etags. Or at least that's how I usually try to write tests: in as orthogonal way as possible. > OK, thanks. I guess we now have the "best etags in the West" (and in > the East as well), as far as Ruby support is concerned. You could say so. It's definitely better than "Exuberant Ctags 5.9~svn20110310" I have installed through the default Ubuntu repositories. It's better [0] than "Ctag Revival" [1], at least until they add support for qualified tags for Ruby [2], which could take a while. We're probably better in some things, and worse in others, than "Ripper Tags" [3]. I haven't tried them yet myself. In any case, it'll give me something to try using day-to-day, when we have at least some solution for tags being out of date (an experimental xref backend that simply rescans the whole project every time comes to mind). [0] https://github.com/universal-ctags/ctags/issues/408 [1] https://github.com/universal-ctags/ctags [2] https://github.com/universal-ctags/ctags/issues/524 [3] https://github.com/tmm1/ripper-tags/