From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: make project--find-in-file generic, add interactive filename to project-find-file Date: Sat, 30 Jan 2016 03:15:45 +0300 Message-ID: <56AC00B1.4050303@yandex.ru> References: <86wpqu8qf9.fsf@stephe-leake.org> <56A9DDA8.9080504@yandex.ru> <86si1i813n.fsf@stephe-leake.org> <86k2mu7yki.fsf@stephe-leake.org> <56AACBF5.3040502@yandex.ru> <86a8no6iuo.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1454112981 10190 80.91.229.3 (30 Jan 2016 00:16:21 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 30 Jan 2016 00:16:21 +0000 (UTC) Cc: emacs-devel To: Stephen Leake Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 30 01:16:15 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aPJD4-000546-Iz for ged-emacs-devel@m.gmane.org; Sat, 30 Jan 2016 01:16:14 +0100 Original-Received: from localhost ([::1]:37090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPJD3-0006oL-Vo for ged-emacs-devel@m.gmane.org; Fri, 29 Jan 2016 19:16:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPJCi-0006mW-10 for emacs-devel@gnu.org; Fri, 29 Jan 2016 19:15:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPJCd-00085M-T7 for emacs-devel@gnu.org; Fri, 29 Jan 2016 19:15:51 -0500 Original-Received: from mail-lf0-x230.google.com ([2a00:1450:4010:c07::230]:33941) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPJCd-00085G-KH for emacs-devel@gnu.org; Fri, 29 Jan 2016 19:15:47 -0500 Original-Received: by mail-lf0-x230.google.com with SMTP id 17so56620073lfz.1 for ; Fri, 29 Jan 2016 16:15:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=jZsPcwCIKj1JJghNrtzRSkd0xXCUS2PzrZswUJ8X+kE=; b=skhqCp14P8dWRl6mZcbGOYGwlgMeqNtkvvJM6oPMoAVCI0sG4ZwmTeGPiREfFxrtJv fUFvzPKW+RPPf2c25k3CCsWZ7+8/mH6ewajLAoWHOF+wHEvqOv18Jy0scKFoh5cVglSo jaEXm8qxOBtaGZv3YNONJYOV+eQxsd8dgxb/uxPQEyh0rXOb7O1T1ie1I/clNrUrqEN+ +GEtuwMXk+ThJn+L2fYpXBse0Ob7bGYRfhGSZTUeNr+N30WQPFYFoT/P5q1IyjHtlEm5 pDB/aWlPUysCFUnERrZdhcLiiRQeNzvFXbA6IcyAhDQhoL3RagIpdyaM7exBh/vK1DZN 4HSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=jZsPcwCIKj1JJghNrtzRSkd0xXCUS2PzrZswUJ8X+kE=; b=WTRRNtCiCRftiO7knERWq/EsPB2PY5O4HMZ3ECzfFHIIS/FsZz9mvt0rTJG5YFb+xu XYCtILLCNrWCtjGV4YdYwHsdZ6UTiKWXGObeKKC3DqIG+5tatyJppXQyU4WdvkvCBVxP IvJw1UT9CoxpH51LDXYV/wi/NbLKirR7ChkN7+G6UZ7aYIiq7HpZRCmTKDq4Bnq9Y1Pc Xcjy8QYLAe3BZyPf9q6bfiihP08GiaoArSaaVDpDiF7GvKJWa5ag0uQoh3IJoJMEiUs8 jiQ5fnhJc3to0ul9lG+FKwLfykFe0LafZ3FQviqjiOO1bKRHFWib/+LgzrGQHxuiNbU4 InTQ== X-Gm-Message-State: AG10YOSCLZcJ9G+d97btBT00RqzuX8d3mzX68/QNeDFvXbSDBhyJbZitg3IGmwP6KzknKw== X-Received: by 10.25.159.211 with SMTP id i202mr4284882lfe.145.1454112946616; Fri, 29 Jan 2016 16:15:46 -0800 (PST) Original-Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id um4sm2350778lbb.1.2016.01.29.16.15.45 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 29 Jan 2016 16:15:45 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 In-Reply-To: <86a8no6iuo.fsf@stephe-leake.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c07::230 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:199014 Archived-At: On 01/30/2016 02:55 AM, Stephen Leake wrote: > I have not thought about that at all. I never felt like I wanted to do > it. I think I did, once or twice over the last few weeks. Projectile includes such command, so putting directories into the completion table might be considered useful. Anyway, no hurry, we're still allowed to break things. > Part of the point of project-find-file is that it allows me to > _ignore_ the directory structure. And you'd be able to "ignore" it to an extent, when visiting directories, by only typing a directory's base name, if it's unique. I don't think we'll introduce any danger to visit a directory when you wanted to visit a file, this way. > I find it cleaner to have a separate cl-defgeneric, so the doc string is > clearly about the generic requirement, and not the default > implementation. You've got a point, but I somewhat prefer them to be kept together: less indirection, easier to follow the most common flow of code. More importantly, both project-ignores and (actually) project-external-roots define their default implementations inline. I think it's better to keep to one style. > And it leaves the default implementation in the same place in the file, > so the git diff is smaller and more usefull. I'd just put the cl-defgeneric where the defun was, really. > Pushed. Thanks.