From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#22470: 25.1.50; vc-annotate (HG) does not display changes within one day (colors) Date: Wed, 27 Jan 2016 03:35:59 +0300 Message-ID: <56A810EF.7090608@yandex.ru> References: <87wpqwick6.fsf@mat.ucm.es> <87si1k5eug.fsf@mat.ucm.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1453855040 20707 80.91.229.3 (27 Jan 2016 00:37:20 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Jan 2016 00:37:20 +0000 (UTC) Cc: 22470@debbugs.gnu.org To: Uwe Brauer , Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 27 01:37:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aOE6f-0007UN-Si for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jan 2016 01:37:10 +0100 Original-Received: from localhost ([::1]:47565 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOE6f-0002D7-99 for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2016 19:37:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53100) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOE6b-0002Cx-LB for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 19:37:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aOE6Y-0001X3-FW for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 19:37:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49759) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aOE6Y-0001Wz-Bu for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 19:37:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aOE6Y-0006Vh-4p for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 19:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jan 2016 00:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22470-submit@debbugs.gnu.org id=B22470.145385496924960 (code B ref 22470); Wed, 27 Jan 2016 00:37:02 +0000 Original-Received: (at 22470) by debbugs.gnu.org; 27 Jan 2016 00:36:09 +0000 Original-Received: from localhost ([127.0.0.1]:37979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aOE5h-0006UV-8f for submit@debbugs.gnu.org; Tue, 26 Jan 2016 19:36:09 -0500 Original-Received: from mail-lb0-f172.google.com ([209.85.217.172]:33519) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aOE5f-0006U5-7F for 22470@debbugs.gnu.org; Tue, 26 Jan 2016 19:36:07 -0500 Original-Received: by mail-lb0-f172.google.com with SMTP id x4so102772234lbm.0 for <22470@debbugs.gnu.org>; Tue, 26 Jan 2016 16:36:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=2i5GsQDrS4gvnw+Pz1IbkwIY3Rh/2BaLVKBBE9dfk88=; b=zTtlijkmiuNts7ihF/tvvNjK2UscG/g3JTNd8mybqX3bt4kaGz3gjBBTt+nIFFVwFK ns64E2yvOVHC4eVXXir6QY56ICJHU+w9df7y4XjL4apN20VV874h+eEesRsWhBd5C+Ll vjj7Uqd4MPw4K57x6cMmZ0igBeNNVSdRT3cuNXYIj3A6rA/PdWxxbkzLt5epCiCH0G7E Fpqjk+QzirZAIPSHUa7eqMmiYXiztHG59KsDko8cuF9bjnBJozsojzvLpcs87lo6zBP+ G7WCbFGEZn1lPg4A++bozvj0JGD44B1icMKZ5pLEzOpuJR7/0TpGsZm1QoISPABt0SoE urmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=2i5GsQDrS4gvnw+Pz1IbkwIY3Rh/2BaLVKBBE9dfk88=; b=OzB/hYayJ2F+MzYuFGyGAvFKrlsSuzfdgohH+njRJ3zAZrrSinlrjYxSPo6850Zx4S eIxvHJCqWtk3pye72krXCk3CXLLwSNnC6XY+fUUrrZtXqPm5YfHqNiyUCH9Cjy3k8AL/ x576fPSO+isZnW1qzYRMM2yvYLpuzB8VHewkmKd4epxxvgTKQ5JxhnMskg9+Y/NpmtFJ mg7Xyl4HvuOLRa0hZVD4Ws17yOwIRgCYiyyVC1T8xElZ2DVYqv3os+rezHqc7tr4heVF o13l6e+pHUG6xwgkISeP/eiH8mgqv5iy3UwrEU2kqcdsn9pR2Q+GPX41IwYOfDXPTh6f FbBA== X-Gm-Message-State: AG10YOT5h53O9nFcPHob7HAO61aadEenfn2tHhgLpyrWW25mFJ+YSGIRzT6FedxkM4dneQ== X-Received: by 10.112.13.8 with SMTP id d8mr9450089lbc.110.1453854961268; Tue, 26 Jan 2016 16:36:01 -0800 (PST) Original-Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id rd3sm498730lbb.2.2016.01.26.16.36.00 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 26 Jan 2016 16:36:00 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 In-Reply-To: <87si1k5eug.fsf@mat.ucm.es> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112019 Archived-At: On 01/26/2016 10:18 PM, Uwe Brauer wrote: > Well I hoped one could generate coloring which reflects changes within > the day, but display the time format deleting the hours and minutes but > it seems not to be possible. Not possible right now, no. > > Finally, at a very quick glance that ahg thing seems to colorize > > based on revision number, not on age, which is a different scheme. > > By revision number do you mean the changeset or the internal local > revision number which hg assigns to its commits but git does not? If it > is the former, maybe that would be a more appropriate model for > vc-annotate? Whatever revision-identifying numbers or strings appear in the output. > > So personally I see no bug here. > > I did not use the word bug, I was asked to send a bug report in order to > find out whether there is a bug. You were asked to file the bug for a different reason: you said there's a difference in behavior here between emasc-25 and master, which would be a problem. Was the version from one of the branches too old? Another problematic thing is visible on your screenshot here: http://lists.gnu.org/archive/html/help-gnu-emacs/2016-01/pngrALEdUf1mc.png Revisions from two consecutive days are still colored the same. At the time, I thought it to be a bug, but it depends on how big is the range of time between the oldest and the newest revisions in the buffer: after all, the annotation palette is limited. If the commits were made in N most recent days, one can to tweak the precision (by customizing vc-annotate-display-mode), but you seem to have figured it out already. Glenn, don't you think it's a problem that we can't distinguish between older commits made on consecutive days? I'd say it's an argument in favor of adopting aHg's scheme, or at least adding it as an option.