all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Uwe Brauer <oub@mat.ucm.es>, Glenn Morris <rgm@gnu.org>
Cc: 22470@debbugs.gnu.org
Subject: bug#22470: 25.1.50; vc-annotate (HG) does not display changes within one day (colors)
Date: Wed, 27 Jan 2016 03:35:59 +0300	[thread overview]
Message-ID: <56A810EF.7090608@yandex.ru> (raw)
In-Reply-To: <87si1k5eug.fsf@mat.ucm.es>

On 01/26/2016 10:18 PM, Uwe Brauer wrote:

> Well I hoped one could generate coloring which reflects changes within
> the day, but display the time format deleting the hours and minutes but
> it seems not to be possible.

Not possible right now, no.

>      > Finally, at a very quick glance that ahg thing seems to colorize
>      > based on revision number, not on age, which is a different scheme.
>
> By revision number do you mean the changeset or the internal local
> revision number which hg assigns to its commits but git does not? If it
> is the former, maybe that would be a more appropriate model for
> vc-annotate?

Whatever revision-identifying numbers or strings appear in the output.

>      > So personally I see no bug here.
>
> I did not use the word bug, I was asked to send a bug report in order to
> find out whether there is a bug.

You were asked to file the bug for a different reason: you said there's 
a difference in behavior here between emasc-25 and master, which would 
be a problem. Was the version from one of the branches too old?

Another problematic thing is visible on your screenshot here: 
http://lists.gnu.org/archive/html/help-gnu-emacs/2016-01/pngrALEdUf1mc.png

Revisions from two consecutive days are still colored the same. At the 
time, I thought it to be a bug, but it depends on how big is the range 
of time between the oldest and the newest revisions in the buffer: after 
all, the annotation palette is limited.

If the commits were made in N most recent days, one can to tweak the 
precision (by customizing vc-annotate-display-mode), but you seem to 
have figured it out already.

Glenn, don't you think it's a problem that we can't distinguish between 
older commits made on consecutive days? I'd say it's an argument in 
favor of adopting aHg's scheme, or at least adding it as an option.





  reply	other threads:[~2016-01-27  0:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-26 15:29 bug#22470: 25.1.50; vc-annotate (HG) does not display changes within one day (colors) Uwe Brauer
2016-01-26 18:50 ` Glenn Morris
2016-01-26 19:18   ` Uwe Brauer
2016-01-27  0:35     ` Dmitry Gutov [this message]
2016-01-27 16:42       ` Glenn Morris
2016-01-27  0:03   ` Dmitry Gutov
2016-01-27 17:43     ` Glenn Morris
2016-01-27  0:40 ` Dmitry Gutov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=56A810EF.7090608@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=22470@debbugs.gnu.org \
    --cc=oub@mat.ucm.es \
    --cc=rgm@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.