From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#22470: 25.1.50; vc-annotate (HG) does not display changes within one day (colors) Date: Wed, 27 Jan 2016 03:03:26 +0300 Message-ID: <56A8094E.9090706@yandex.ru> References: <87wpqwick6.fsf@mat.ucm.es> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1453853063 26746 80.91.229.3 (27 Jan 2016 00:04:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Jan 2016 00:04:23 +0000 (UTC) Cc: 22470@debbugs.gnu.org To: Glenn Morris , Uwe Brauer Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Jan 27 01:04:13 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aODak-0007S5-HD for geb-bug-gnu-emacs@m.gmane.org; Wed, 27 Jan 2016 01:04:10 +0100 Original-Received: from localhost ([::1]:47495 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aODaj-0001B2-Kv for geb-bug-gnu-emacs@m.gmane.org; Tue, 26 Jan 2016 19:04:09 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47439) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aODaf-0001AQ-U8 for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 19:04:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aODac-0003Co-Je for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 19:04:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49755) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aODac-0003Cj-Fb for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 19:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aODac-0005kZ-8y for bug-gnu-emacs@gnu.org; Tue, 26 Jan 2016 19:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 27 Jan 2016 00:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22470 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 22470-submit@debbugs.gnu.org id=B22470.145385301522069 (code B ref 22470); Wed, 27 Jan 2016 00:04:02 +0000 Original-Received: (at 22470) by debbugs.gnu.org; 27 Jan 2016 00:03:35 +0000 Original-Received: from localhost ([127.0.0.1]:37975 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aODaB-0005jt-MJ for submit@debbugs.gnu.org; Tue, 26 Jan 2016 19:03:35 -0500 Original-Received: from mail-lf0-f45.google.com ([209.85.215.45]:36570) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aODa9-0005jU-Mr for 22470@debbugs.gnu.org; Tue, 26 Jan 2016 19:03:34 -0500 Original-Received: by mail-lf0-f45.google.com with SMTP id h129so117126586lfh.3 for <22470@debbugs.gnu.org>; Tue, 26 Jan 2016 16:03:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=hnGhFoi86hg0l0nUIofYghYIOLfienkCDDo9woWHwZY=; b=RD5te8E3yQgrYZ73unEnERuA1dTtqWTpixUjkhOK8DSZOMwVudHtuAjhCU6uGwi0GF RIQXOvMJ6NH+7fepy+XTjVPPIDsLb9xu++IXZwQ+R/Ak0YsR21VMSFxqW9Sf1+8PtM+N OxQl5iK2swC90Pr7zknNXK8oJd5RbRJyhfuOxtDYA9ISNkvxJ8eYYkHkE1w5CGLkq+Vm Pb4qSCDsfRThv7pC1c8nfLZK3AvZpjwqdzUxVInramdPS8wXfgJKnWHh+UFYIz7ElTSG AOWPLsM2H9BtsyMI5LJDvMqSMZjuHg5GCrz8X2imHObMPiQe95lzwO3WvoEV5ei30D9g eahg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:cc:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=hnGhFoi86hg0l0nUIofYghYIOLfienkCDDo9woWHwZY=; b=kGvVU+++3+HtGR+KUylL0lPajAMfsoiAmphEb6cvrOJFWm3kqautqDcZ/OcX+R8UMn VvlNiwzPVWzdXyIPjQwRfn49Z77VnLgHugzzSCqZh5u7rGA/5isg5N5FcUfmriLggjw8 xRT2ro8WcSUmud0FnfcmV+3fpOXArJIUyMLL57eFz3cLytyCMEdp161A+Bzz4MdWQso9 GL6WCwkjafsATlb5FuiwWL5dzv8ltZHsFrL0/DHPvloO+Ekyz3pGI7Vl6SqxB4Wc79Wa f1LWSTyCLVHb63mmcjzfHx+bAtxvfO+pdENj81RZqlQqUqifUzgulOzzLpcS2OIZb70s ecwA== X-Gm-Message-State: AG10YOQVDfOaA/GPPcUqWkf9U5ghv/f46VgX0TGrewhn+eUQ1RJudSsFsjNM4tvzxHkDiQ== X-Received: by 10.25.83.193 with SMTP id h184mr9693490lfb.6.1453853007882; Tue, 26 Jan 2016 16:03:27 -0800 (PST) Original-Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id o82sm482993lfo.47.2016.01.26.16.03.26 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 26 Jan 2016 16:03:26 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112018 Archived-At: On 01/26/2016 09:50 PM, Glenn Morris wrote: > FWIW, I see no difference between current master and emacs-25. > It also seems self-evident to me that if you've set the date to only > display at the level of days, you'll only get colouring at the same > level. > > The current vc-annotate behavior for hg seems consistent with eg git. Both true statements. However, it is possible to both show short dates and colorize at the minute resolution, e.g. by asking for a detailed date format from the backend program, and then turning those dates into short ones when parsing the output. Something to consider for the next release, maybe. > Finally, at a very quick glance that ahg thing seems to colorize based > on revision number, not on age, which is a different scheme. I do wonder if aHg's approach is better. The default palette mapping doesn't convey to me, personally, any particular information about time. I had to glance at the relevant variable and its value to understand that red means "new", blue means "old", and green and orange are somewhere in between. I'll probably forget this soon enough. The only way we could make the color intuitive, I think, is by using some linear gradient, and then, I fear, the difference in color between revisions made on close days might be too small to notice. Simply showing that these lines of code were produce by the same revision, and those and those by two different ones, seems more valuable anyway.