From: Eli Zaretskii <eliz@gnu.org>
To: Tassilo Horn <tsdh@gnu.org>,Federico Tedin <federicotedin@gmail.com>
Cc: 33684@debbugs.gnu.org, jidanni@jidanni.org
Subject: bug#33684: DocView bombs out upon password protected PDFs
Date: Mon, 04 Feb 2019 08:29:46 +0200 [thread overview]
Message-ID: <56A449C2-6DF7-4073-BD68-14216F8746F8@gnu.org> (raw)
In-Reply-To: <87k1igyuno.fsf@gnu.org>
On February 4, 2019 7:44:43 AM GMT+02:00, Tassilo Horn <tsdh@gnu.org> wrote:
> Federico Tedin <federicotedin@gmail.com> writes:
>
> Hi Federico,
>
> > Hi Tassilo, thanks for your feedback. I've created a new patch with
> > the commit message, and also added an entry to NEWS. I'm attaching
> it
> > here.
>
> Looks perfect. Small nitpick: we use * for bullet points instead of -
> in the commit message, but I can amend that. I can't push it from
> work,
> so I'll do it this evening.
When you do, please be sure to amend the log message to mention the bug number.
Also, the doc strings of 2 of the new functions need to be reformatted to have the first line be a complete sentence. (Just move the second sentence to the next line, I'd say.)
Thanks.
next prev parent reply other threads:[~2019-02-04 6:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 10:52 bug#33684: DocView bombs out upon password protected PDFs 積丹尼 Dan Jacobson
2019-01-27 2:14 ` Federico Tedin
2019-02-01 9:33 ` Eli Zaretskii
2019-02-01 10:12 ` Tassilo Horn
2019-02-01 10:34 ` Eli Zaretskii
2019-02-01 10:42 ` Federico Tedin
2019-02-02 20:58 ` Federico Tedin
2019-02-03 8:40 ` Tassilo Horn
2019-02-03 16:55 ` Federico Tedin
2019-02-04 5:44 ` Tassilo Horn
2019-02-04 6:29 ` Eli Zaretskii [this message]
2019-02-04 6:52 ` Tassilo Horn
2019-02-04 15:49 ` Tassilo Horn
2019-02-04 21:24 ` Federico Tedin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A449C2-6DF7-4073-BD68-14216F8746F8@gnu.org \
--to=eliz@gnu.org \
--cc=33684@debbugs.gnu.org \
--cc=federicotedin@gmail.com \
--cc=jidanni@jidanni.org \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.