From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: tell xref-collect-references to use the right root directory Date: Thu, 21 Jan 2016 22:38:31 +0300 Message-ID: <56A133B7.9000604@yandex.ru> References: <86io2m69hi.fsf@stephe-leake.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1453405132 20695 80.91.229.3 (21 Jan 2016 19:38:52 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 21 Jan 2016 19:38:52 +0000 (UTC) To: Stephen Leake , emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jan 21 20:38:52 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aML4F-00061J-HF for ged-emacs-devel@m.gmane.org; Thu, 21 Jan 2016 20:38:51 +0100 Original-Received: from localhost ([::1]:49533 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aML4E-0008IA-In for ged-emacs-devel@m.gmane.org; Thu, 21 Jan 2016 14:38:50 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35364) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aML40-0008HZ-WD for emacs-devel@gnu.org; Thu, 21 Jan 2016 14:38:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aML3x-0002oC-ON for emacs-devel@gnu.org; Thu, 21 Jan 2016 14:38:36 -0500 Original-Received: from mail-lb0-x235.google.com ([2a00:1450:4010:c04::235]:35356) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aML3x-0002o4-G5 for emacs-devel@gnu.org; Thu, 21 Jan 2016 14:38:33 -0500 Original-Received: by mail-lb0-x235.google.com with SMTP id bc4so29247192lbc.2 for ; Thu, 21 Jan 2016 11:38:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-type:content-transfer-encoding; bh=A2Za8kNFaJTXnbgausySzvdc78Hdn12SNi1+vVvnwDQ=; b=PplOCQO2IWwL6nDIfCaXYCGQKGLxDtp0DpkS4+OoXWdTlkGRumhejZ+w+a8aXJrPN6 zNWGlWKoJ6fpCPyIMQlxWC4aWSt42DC8oEf3ME/7CVvhm7B+YM0+dTOAe/v+gLcWk1Xx d2m/L6BkV2nYf239pUQ7w1n7x+jng+lcW9CkYtDf8E0eU3kvc0XB/iP9BzRPmVCW3jR1 CaH9jXRwbBM/CteP4/M+ILLN6RCXtg+VG6U2W/sqFr0mUK4xFUqs/j3KEZtyK/A766sU 9orfu02hv9xfAidZ+mtmwwGSP7FORb1KzV54LSgyMPjjZKlLT8vFL1L2YHy2MgTG999t oS+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-type :content-transfer-encoding; bh=A2Za8kNFaJTXnbgausySzvdc78Hdn12SNi1+vVvnwDQ=; b=WOucpLlHXbda3BRisMggIAvCyx6drIZMOv//w7JoKD1fgKUB7QEvAkg1LqftbJqhGo v4oPXGEwK9ekGXw851ILeJGQhCgdq1asEwaAfSz0r/EXDJlLPLZ35ha35+xQLtfWJnYT mZG5TqFIMY7hiMuirKxG3tSH2zmVcS+Flfxyv+XEWkr+RpTpo/LkaLh/E2rsbCDUlDZy EMYIxF/uYTERE54Yn9eID1ABYRn0rpM8ISd+5qMvRjTa7AlJda7dXYB44gwBItiutdin m9C22jiBroeCaiu+YnebnL7aBT3oc1pkcJj+NVYNKX+RKOlR2Iraf1Kbp+7YdiGWLueS hsyg== X-Gm-Message-State: ALoCoQknn8W0x+Nq5XEYLdaJVqGLQ/rM/UcWkQdOR+QN9oV1Z3J7X2HHUexEROO8u2N9DwrkLcMY5zHLkrcDei/5gCCbVJsbGQ== X-Received: by 10.112.137.129 with SMTP id qi1mr15889032lbb.31.1453405112598; Thu, 21 Jan 2016 11:38:32 -0800 (PST) Original-Received: from [192.168.1.190] ([178.252.127.222]) by smtp.googlemail.com with ESMTPSA id m3sm404769lfb.8.2016.01.21.11.38.31 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Jan 2016 11:38:31 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:44.0) Gecko/20100101 Thunderbird/44.0 In-Reply-To: <86io2m69hi.fsf@stephe-leake.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2a00:1450:4010:c04::235 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198526 Archived-At: On 01/21/2016 10:03 PM, Stephen Leake wrote: > Any objections to this patch? LGTM, thanks. > --- a/lisp/progmodes/xref.el > +++ b/lisp/progmodes/xref.el > @@ -861,7 +861,13 @@ xref-collect-references > (cl-assert (directory-name-p dir)) > (require 'semantic/symref) > (defvar semantic-symref-tool) > - (let* ((default-directory dir) > + > + ;; Some symref backends use `ede-project-root-directory' as the root > + ;; directory for the search, rather than `default-directory'. Since > + ;; the caller has specified `dir', we bind `ede-minor-mode' to nil > + ;; to force the backend to use `default-directory'. > + (let* ((ede-minor-mode nil) > + (default-directory dir) > (semantic-symref-tool 'detect) > (res (semantic-symref-find-references-by-name symbol 'subdirs)) > (hits (and res (oref res hit-lines)))