From: Dmitry Gutov <dgutov@yandex.ru>
To: Stephen Leake <stephen_leake@stephe-leake.org>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: tell xref-collect-references to use the right root directory
Date: Thu, 21 Jan 2016 22:38:31 +0300 [thread overview]
Message-ID: <56A133B7.9000604@yandex.ru> (raw)
In-Reply-To: <86io2m69hi.fsf@stephe-leake.org>
On 01/21/2016 10:03 PM, Stephen Leake wrote:
> Any objections to this patch?
LGTM, thanks.
> --- a/lisp/progmodes/xref.el
> +++ b/lisp/progmodes/xref.el
> @@ -861,7 +861,13 @@ xref-collect-references
> (cl-assert (directory-name-p dir))
> (require 'semantic/symref)
> (defvar semantic-symref-tool)
> - (let* ((default-directory dir)
> +
> + ;; Some symref backends use `ede-project-root-directory' as the root
> + ;; directory for the search, rather than `default-directory'. Since
> + ;; the caller has specified `dir', we bind `ede-minor-mode' to nil
> + ;; to force the backend to use `default-directory'.
> + (let* ((ede-minor-mode nil)
> + (default-directory dir)
> (semantic-symref-tool 'detect)
> (res (semantic-symref-find-references-by-name symbol 'subdirs))
> (hits (and res (oref res hit-lines)))
prev parent reply other threads:[~2016-01-21 19:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 19:03 tell xref-collect-references to use the right root directory Stephen Leake
2016-01-21 19:38 ` Dmitry Gutov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56A133B7.9000604@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=stephen_leake@stephe-leake.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.