From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: useless variable handle_user_signal_hook? Date: Wed, 20 Jan 2016 14:19:39 -0800 Organization: UCLA Computer Science Department Message-ID: <56A007FB.4070600@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060409060008030101040707" X-Trace: ger.gmane.org 1453328410 6415 80.91.229.3 (20 Jan 2016 22:20:10 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 20 Jan 2016 22:20:10 +0000 (UTC) Cc: Emacs development discussions To: YAMAMOTO Mitsuharu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jan 20 23:20:01 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aM16d-0003oY-6h for ged-emacs-devel@m.gmane.org; Wed, 20 Jan 2016 23:19:59 +0100 Original-Received: from localhost ([::1]:45275 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM16c-0003hk-JI for ged-emacs-devel@m.gmane.org; Wed, 20 Jan 2016 17:19:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:35383) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM16Q-0003hc-8J for emacs-devel@gnu.org; Wed, 20 Jan 2016 17:19:46 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aM16L-0002IT-6N for emacs-devel@gnu.org; Wed, 20 Jan 2016 17:19:46 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58093) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aM16K-0002IE-Sj for emacs-devel@gnu.org; Wed, 20 Jan 2016 17:19:41 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 342F316017F; Wed, 20 Jan 2016 14:19:40 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id wGPM50bh33xs; Wed, 20 Jan 2016 14:19:39 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8C17A160817; Wed, 20 Jan 2016 14:19:39 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id aJWD1lNjV13G; Wed, 20 Jan 2016 14:19:39 -0800 (PST) Original-Received: from penguin.cs.ucla.edu (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 71B7216017F; Wed, 20 Jan 2016 14:19:39 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198467 Archived-At: This is a multi-part message in MIME format. --------------060409060008030101040707 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit The attached patch (recently added to emacs-25) introduced a C variable handle_user_signal_hook that is useless because it is always null. Although the variable can be optimized away by link-time optimization, typically it is not optimized away. Are you intending to add further patches to emacs-25 that need this variable, before Emacs 25 is released? If not, how about if we remove this variable for now? We can always add it back again later, when it's needed. --------------060409060008030101040707 Content-Type: application/x-patch; name="0001-Add-handle_user_signal_hook.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-Add-handle_user_signal_hook.patch" RnJvbSA2ZWUzMjdkOGExMDA0N2MxNzE3MzU4Y2MxNzllZDhkMWZiMzM4OWViIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBZQU1BTU9UTyBNaXRzdWhhcnUgPG1pdHVoYXJ1QG1h dGgucy5jaGliYS11LmFjLmpwPgpEYXRlOiBUaHUsIDMxIERlYyAyMDE1IDExOjE3OjM1ICsw OTAwClN1YmplY3Q6IFtQQVRDSF0gQWRkIGhhbmRsZV91c2VyX3NpZ25hbF9ob29rCgoqIHNy Yy9rZXlib2FyZC5oIChoYW5kbGVfdXNlcl9zaWduYWxfaG9vayk6IE5ldyBkZWNsYXJhdGlv bi4KKiBzcmMva2V5Ym9hcmQuYyAoaGFuZGxlX3VzZXJfc2lnbmFsX2hvb2spOiBOZXcgdmFy aWFibGUuCihoYW5kbGVfdXNlcl9zaWduYWwpOiBDYWxsIGl0LgotLS0KIHNyYy9rZXlib2Fy ZC5jIHwgNSArKysrKwogc3JjL2tleWJvYXJkLmggfCAyICsrCiAyIGZpbGVzIGNoYW5nZWQs IDcgaW5zZXJ0aW9ucygrKQoKZGlmZiAtLWdpdCBhL3NyYy9rZXlib2FyZC5jIGIvc3JjL2tl eWJvYXJkLmMKaW5kZXggOWViZDg2Yi4uYjBmZTMyOCAxMDA2NDQKLS0tIGEvc3JjL2tleWJv YXJkLmMKKysrIGIvc3JjL2tleWJvYXJkLmMKQEAgLTcxMjQsNiArNzEyNCw5IEBAIHN0cnVj dCB1c2VyX3NpZ25hbF9pbmZvCiAvKiBMaXN0IG9mIHVzZXIgc2lnbmFscy4gICovCiBzdGF0 aWMgc3RydWN0IHVzZXJfc2lnbmFsX2luZm8gKnVzZXJfc2lnbmFscyA9IE5VTEw7CiAKKy8q IEZ1bmN0aW9uIGNhbGxlZCB3aGVuIGhhbmRsaW5nIHVzZXIgc2lnbmFscy4gICovCit2b2lk ICgqaGFuZGxlX3VzZXJfc2lnbmFsX2hvb2spIChpbnQpOworCiB2b2lkCiBhZGRfdXNlcl9z aWduYWwgKGludCBzaWcsIGNvbnN0IGNoYXIgKm5hbWUpCiB7CkBAIC03MTcyLDYgKzcxNzUs OCBAQCBoYW5kbGVfdXNlcl9zaWduYWwgKGludCBzaWcpCiAgICAgICAgICAgfQogCiAJcC0+ bnBlbmRpbmcrKzsKKwlpZiAoaGFuZGxlX3VzZXJfc2lnbmFsX2hvb2spCisJICAoKmhhbmRs ZV91c2VyX3NpZ25hbF9ob29rKSAoc2lnKTsKICNpZmRlZiBVU0FCTEVfU0lHSU8KIAlpZiAo aW50ZXJydXB0X2lucHV0KQogCSAgaGFuZGxlX2lucHV0X2F2YWlsYWJsZV9zaWduYWwgKHNp Zyk7CmRpZmYgLS1naXQgYS9zcmMva2V5Ym9hcmQuaCBiL3NyYy9rZXlib2FyZC5oCmluZGV4 IDg5MGQyNGUuLjQ1NThiZDYgMTAwNjQ0Ci0tLSBhL3NyYy9rZXlib2FyZC5oCisrKyBiL3Ny Yy9rZXlib2FyZC5oCkBAIC00MTUsNiArNDE1LDggQEAgZXh0ZXJuIHZvaWQgdW51c2VfbWVu dV9pdGVtcyAodm9pZCk7CiAjZGVmaW5lIEVWRU5UX0hFQURfS0lORChldmVudF9oZWFkKSBc CiAgIChGZ2V0ICgoZXZlbnRfaGVhZCksIFFldmVudF9raW5kKSkKIAorZXh0ZXJuIHZvaWQg KCpoYW5kbGVfdXNlcl9zaWduYWxfaG9vaykgKGludCk7CisKIC8qIFRydWUgd2hpbGUgZG9p bmcga2JkIGlucHV0LiAgKi8KIGV4dGVybiBib29sIHdhaXRpbmdfZm9yX2lucHV0OwogCi0t IAoyLjUuMAoK --------------060409060008030101040707--