useless variable handle_user_signal_hook?

useless variable handle_user_signal_hook?

[Paul Eggert]

[-- Attachment #1: Type: text/plain, Size: 471 bytes --]

The attached patch (recently added to emacs-25) introduced a C variable 
handle_user_signal_hook that is useless because it is always null. 
Although the variable can be optimized away by link-time optimization, 
typically it is not optimized away.

Are you intending to add further patches to emacs-25 that need this 
variable, before Emacs 25 is released? If not, how about if we remove 
this variable for now? We can always add it back again later, when it's 
needed.

[-- Attachment #2: 0001-Add-handle_user_signal_hook.patch --]
[-- Type: application/x-patch, Size: 1467 bytes --]

Re: useless variable handle_user_signal_hook?

[YAMAMOTO Mitsuharu]

>>>>> On Wed, 20 Jan 2016 14:19:39 -0800, Paul Eggert <eggert@cs.ucla.edu> said:

> The attached patch (recently added to emacs-25) introduced a C
> variable handle_user_signal_hook that is useless because it is
> always null.  Although the variable can be optimized away by
> link-time optimization, typically it is not optimized away.

> Are you intending to add further patches to emacs-25 that need this
> variable, before Emacs 25 is released? If not, how about if we
> remove this variable for now? We can always add it back again later,
> when it's needed.

Feel free to remove it.  It is currently only necessary for the Mac
port.  (Of course, it might be useful if the `select' emulation in
another port wants to get notified when a user signal has arrived.)

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp