From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jussi Lahdenniemi Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Override Windows default Win-* key combinations when using Emacs Date: Sat, 16 Jan 2016 13:00:35 +0200 Organization: Aprikoodi Oy Message-ID: <569A22D3.7070208@aprikoodi.fi> References: <568BBC58.50702@aprikoodi.fi> <83y4c43qkh.fsf@gnu.org> <5691667C.5000009@aprikoodi.fi> <838u3wkkvb.fsf@gnu.org> <5694E07E.8010005@aprikoodi.fi> <83fuy2kd2w.fsf@gnu.org> <56961607.2090504@aprikoodi.fi> <569634D6.6030404@aprikoodi.fi> <83oacpiial.fsf@gnu.org> <5697995B.5010306@aprikoodi.fi> <83mvs8gh7n.fsf@gnu.org> <83vb6tethb.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Trace: ger.gmane.org 1452942076 23224 80.91.229.3 (16 Jan 2016 11:01:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Jan 2016 11:01:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jan 16 12:01:07 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aKObS-0004Ko-2V for ged-emacs-devel@m.gmane.org; Sat, 16 Jan 2016 12:01:06 +0100 Original-Received: from localhost ([::1]:50330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKObR-0003tA-B9 for ged-emacs-devel@m.gmane.org; Sat, 16 Jan 2016 06:01:05 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aKObE-0003sw-1x for emacs-devel@gnu.org; Sat, 16 Jan 2016 06:00:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aKObB-0006Hc-2x for emacs-devel@gnu.org; Sat, 16 Jan 2016 06:00:51 -0500 Original-Received: from nbjjceehcbh.turbo-smtp.net ([199.244.72.17]:58300) by eggs.gnu.org with smtp (Exim 4.71) (envelope-from ) id 1aKOb9-0006Gw-NT for emacs-devel@gnu.org; Sat, 16 Jan 2016 06:00:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aprikoodi.fi; s=turbo-smtp; x=1453546847; h=DomainKey-Signature: Received:Received:Subject:To:References:Cc:From:Organization: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=FVrMjDY+/MBGZ6Sl8kim/C2Fu8g3X1JDxm wimM05qjw=; b=n5jW2FpCXbmC7A65u/pqB25HMpkgBa50NwFMUjHLsfSD4apKaU 8bshNCZ8WgA7dft8VpQplmPJI3be2Dz+HjLgwdcIjKgKE9qt+ZjnsEJitsqezR8N BamBtDcbixS3Cxl9nPlIqk0qQXmuv6RMxHO4zBE/LTklt7f2Azg4y1QdA= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=turbo-smtp; d=aprikoodi.fi; h=Received:Received:X-TurboSMTP-Tracking:Subject:To:References:Cc:From:Organization:Message-ID:Date:User-Agent:MIME-Version:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=eiBVXaZt0YjIdq6gwLxKEJJfEJnsuluM3gIjuS9Q8oGRmQrneJXVK6HHTrJZIn BXX8WP7ShwINLAcNgihw7aaYBV4fGwtH2YvJxX75d1cCl2oGlKfrEa40PxLIjtLG Cz/CEgOLZS3Mt+db+glEqOkAvPp29kG8/iKEtkN6N3RUw=; Original-Received: (qmail 23172 invoked from network); 16 Jan 2016 11:00:42 -0000 Original-Received: from unknown (HELO ?192.168.100.12?) (authenticated@109.240.193.65) by turbo-smtp.com with SMTP; 16 Jan 2016 11:00:42 -0000 X-TurboSMTP-Tracking: 2739111174 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 In-Reply-To: <83vb6tethb.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 199.244.72.17 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198194 Archived-At: On 16.1.2016 11.58, Eli Zaretskii wrote: >> Thanks, I will push these to the emacs-25 branch soon. > > Done now. Thanks! > Note one gotcha with calling functions that might not be available at > run time: you cannot rely on a static function pointer to be NULL when > Emacs starts. That's because when Emacs is dumped, the value of the > pointer from the system where Emacs is built is (or could be) recorded > in the dumped binary, and is non-NULL. So you must explicitly zero it > out every Emacs startup; see the various globals_of_w32* functions > which do this for several such pointers. I added a line to reset the > resetstkovflw pointer when Emacs starts. Oh, of course. Didn't think about that. Thanks! > P.S. These patches all but exhaust your grace limit of contributed > code we can accept without your assigning copyright, so I hope your > legal paperwork is well under way, and we will be able to accept your > contributions soon. My paperwork went into an extra round this week, as I had signed the first set of papers with a date in 2015. I expect the new set to reach FSF during the next week, if the mail is as quick this time as it was with the first set. -- Jussi Lahdenniemi